src/list-inl.h - Issue 1314253006: Fix a potential overflow of binary search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/list-inl.h

Issue 1314253006: Fix a potential overflow of binary search (Closed) Base URL: git@github.com:v8/v8-git-mirror.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/list-inl.h

diff --git a/src/list-inl.h b/src/list-inl.h

index 94ef14dbaedba2f1ef1f76f02ae2e563880d0219..5a247d5fd766da538c0cc433d3600bb27e9d4abe 100644

--- a/src/list-inl.h

+++ b/src/list-inl.h

@@ -250,7 +250,7 @@ int SortedListBSearch(const List<T>& list, P cmp) {

int low = 0;

int high = list.length() - 1;

while (low <= high) {

- int mid = (low + high) / 2;

+ int mid = low + (high - low) / 2;

T mid_elem = list[mid];

if (cmp(&mid_elem) > 0) {

« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »