Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: src/list-inl.h

Issue 1314253006: Fix a potential overflow of binary search (Closed) Base URL: git@github.com:v8/v8-git-mirror.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LIST_INL_H_ 5 #ifndef V8_LIST_INL_H_
6 #define V8_LIST_INL_H_ 6 #define V8_LIST_INL_H_
7 7
8 #include "src/list.h" 8 #include "src/list.h"
9 9
10 #include "src/base/macros.h" 10 #include "src/base/macros.h"
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 void List<T, P>::StableSort() { 243 void List<T, P>::StableSort() {
244 ToVector().StableSort(); 244 ToVector().StableSort();
245 } 245 }
246 246
247 247
248 template <typename T, typename P> 248 template <typename T, typename P>
249 int SortedListBSearch(const List<T>& list, P cmp) { 249 int SortedListBSearch(const List<T>& list, P cmp) {
250 int low = 0; 250 int low = 0;
251 int high = list.length() - 1; 251 int high = list.length() - 1;
252 while (low <= high) { 252 while (low <= high) {
253 int mid = (low + high) / 2; 253 int mid = low + (high - low) / 2;
254 T mid_elem = list[mid]; 254 T mid_elem = list[mid];
255 255
256 if (cmp(&mid_elem) > 0) { 256 if (cmp(&mid_elem) > 0) {
257 high = mid - 1; 257 high = mid - 1;
258 continue; 258 continue;
259 } 259 }
260 if (cmp(&mid_elem) < 0) { 260 if (cmp(&mid_elem) < 0) {
261 low = mid + 1; 261 low = mid + 1;
262 continue; 262 continue;
263 } 263 }
(...skipping 18 matching lines...) Expand all
282 282
283 template <typename T> 283 template <typename T>
284 int SortedListBSearch(const List<T>& list, T elem) { 284 int SortedListBSearch(const List<T>& list, T elem) {
285 return SortedListBSearch<T, ElementCmp<T> > (list, ElementCmp<T>(elem)); 285 return SortedListBSearch<T, ElementCmp<T> > (list, ElementCmp<T>(elem));
286 } 286 }
287 287
288 288
289 } } // namespace v8::internal 289 } } // namespace v8::internal
290 290
291 #endif // V8_LIST_INL_H_ 291 #endif // V8_LIST_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698