Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 13142007: IDL: Autogenerate thunk for PPB_Gamepad. (Closed)

Created:
7 years, 8 months ago by teravest
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

IDL: Autogenerate thunk for PPB_Gamepad. This required adding two features to the thunk generator. * Support for a 'singleton_resource' annotation, which forces the use of EnterInstanceAPI. * When a function fails in the thunk layer, and it returns void, automatically zero out the output arguments. This will probably have to be moved to an annotation later, but seems like a good heuristic for now. BUG=187666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191477

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unnecessary comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -31 lines) Patch
M ppapi/api/ppb_gamepad.idl View 3 chunks +3 lines, -2 lines 0 comments Download
M ppapi/generators/idl_thunk.py View 1 5 chunks +62 lines, -21 lines 0 comments Download
M ppapi/thunk/ppb_gamepad_thunk.cc View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
teravest
7 years, 8 months ago (2013-03-28 21:54:37 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/13142007/diff/1/ppapi/generators/idl_thunk.py File ppapi/generators/idl_thunk.py (right): https://codereview.chromium.org/13142007/diff/1/ppapi/generators/idl_thunk.py#newcode101 ppapi/generators/idl_thunk.py:101: # Clip off _dev suffix. nit: _trusted (or ...
7 years, 8 months ago (2013-03-28 22:11:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/13142007/5001
7 years, 8 months ago (2013-03-29 14:41:29 UTC) #3
teravest
On Thu, Mar 28, 2013 at 4:11 PM, <dmichael@chromium.org> wrote: > lgtm > > > ...
7 years, 8 months ago (2013-03-29 14:41:36 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 00:13:26 UTC) #5
Message was sent while issue was closed.
Change committed as 191477

Powered by Google App Engine
This is Rietveld 408576698