Moved code implementing message-only windows to a dedicated class (Windows only).

Moved code implementing message-only windows to a dedicated class (Windows only).

This CL merges three implementations of message-only windows that we have in remoting into one class remoting::win::MessageWindow.

Collateral changes:
 - The local input monitor now closes the connection if it cannot subscribe to the raw mouse input. Without this the remote user could potentially prevent the local user from closing the connection.
 - The clipboard window can be started only once, just like its owner.

TEST=remoting_unittests.MessageWindowTest


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191532

[alexeypa (please no reviews), 2013-03-28 03:40:46]

Daniel, PTAL. Lambros, please rubber-stamp as needed.

[dcaiafa, 2013-03-28 23:25:35]

https://codereview.chromium.org/13142002/diff/1/remoting/host/clipboard_win.cc
File remoting/host/clipboard_win.cc (right):

https://codereview.chromium.org/13142002/diff/1/remoting/host/clipboard_win.c...
remoting/host/clipboard_win.cc:125: // Used to subsribe to WM_CLIPBOARDUPDATE
messages.
nit: subscribe

https://codereview.chromium.org/13142002/diff/1/remoting/host/local_input_mon...
File remoting/host/local_input_monitor_win.cc (right):

https://codereview.chromium.org/13142002/diff/1/remoting/host/local_input_mon...
remoting/host/local_input_monitor_win.cc:234: // |window_->hwnd()| is not
available yet. Enable raw mouse input once
Refer to my comment on MessageWindow. I think hwnd() should be available on
WM_CREATE. If I were writing a Delegate, I'd certainly expect it so.

https://codereview.chromium.org/13142002/diff/1/remoting/host/win/message_win...
File remoting/host/win/message_window.cc (right):

https://codereview.chromium.org/13142002/diff/1/remoting/host/win/message_win...
remoting/host/win/message_window.cc:90: // Store |this| to the window's user
data.
You're actually storing delegate here, not |this|. I'd consider storing |this|,
as the comment currently states, and use it to set window_ on WM_CREATE. I think
it's simpler for the delegate if hwnd() is available on WM_CREATE.

[alexeypa (please no reviews), 2013-03-29 16:57:00]

https://codereview.chromium.org/13142002/diff/1/remoting/host/clipboard_win.cc
File remoting/host/clipboard_win.cc (right):

https://codereview.chromium.org/13142002/diff/1/remoting/host/clipboard_win.c...
remoting/host/clipboard_win.cc:125: // Used to subsribe to WM_CLIPBOARDUPDATE
messages.
On 2013/03/28 23:25:35, dcaiafa wrote:
> nit: subscribe

Done.

https://codereview.chromium.org/13142002/diff/1/remoting/host/local_input_mon...
File remoting/host/local_input_monitor_win.cc (right):

https://codereview.chromium.org/13142002/diff/1/remoting/host/local_input_mon...
remoting/host/local_input_monitor_win.cc:234: // |window_->hwnd()| is not
available yet. Enable raw mouse input once
On 2013/03/28 23:25:35, dcaiafa wrote:
> Refer to my comment on MessageWindow. I think hwnd() should be available on
> WM_CREATE. If I were writing a Delegate, I'd certainly expect it so.

Done.

https://codereview.chromium.org/13142002/diff/1/remoting/host/win/message_win...
File remoting/host/win/message_window.cc (right):

https://codereview.chromium.org/13142002/diff/1/remoting/host/win/message_win...
remoting/host/win/message_window.cc:90: // Store |this| to the window's user
data.
On 2013/03/28 23:25:35, dcaiafa wrote:
> You're actually storing delegate here, not |this|. I'd consider storing
|this|,
> as the comment currently states, and use it to set window_ on WM_CREATE. I
think
> it's simpler for the delegate if hwnd() is available on WM_CREATE.

Done.

[dcaiafa, 2013-03-29 17:42:26]

lgtm

[Lambros, 2013-03-29 23:27:26]

lgtm

[commit-bot: I haz the power, 2013-03-29 23:40:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/13142002/7001

[commit-bot: I haz the power, 2013-03-30 17:01:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/13142002/7001

[commit-bot: I haz the power, 2013-03-30 18:00:09]

Change committed as 191532