Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issue 1314193003: Revert of Native context: install array methods via runtime import. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Camillo Bruni, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Native context: install array methods via runtime import. (patchset #1 id:1 of https://codereview.chromium.org/1324483002/ ) Reason for revert: This breaks builds without i18n support. Bisected locally. See builder: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/4285 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/4285/steps/Check/logs/Threading1 # Fatal error in .././src/objects-inl.h, line 1381 # Check failed: READ_FIELD(this, offset)->IsSmi(). Original issue's description: > Native context: install array methods via runtime import. > > R=cbruni@chromium.org > > Committed: https://crrev.com/08ee2132a818a0178038afa521ca06c297195cc9 > Cr-Commit-Position: refs/heads/master@{#30446} TBR=cbruni@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/641706b4ddf94fef75a87b47a1ea47c64bb1ba60 Cr-Commit-Position: refs/heads/master@{#30462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -158 lines) Patch
M src/array.js View 5 chunks +46 lines, -51 lines 0 comments Download
M src/bootstrapper.cc View 23 chunks +116 lines, -107 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Native context: install array methods via runtime import.
5 years, 3 months ago (2015-08-31 10:09:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314193003/1
5 years, 3 months ago (2015-08-31 10:09:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 10:09:56 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/641706b4ddf94fef75a87b47a1ea47c64bb1ba60 Cr-Commit-Position: refs/heads/master@{#30462}
5 years, 3 months ago (2015-08-31 10:10:07 UTC) #4
Michael Achenbach
5 years, 3 months ago (2015-08-31 10:21:59 UTC) #5
Message was sent while issue was closed.
@cbruni: Could you maybe check what was wrong with the original CL as Yang's OOO
now?

Powered by Google App Engine
This is Rietveld 408576698