Remove unwanted images in Gold

Remove unwanted images in Gold

These extra outputs were caused by recent changes to
push_codec_srcs.
https://codereview.chromium.org/1327433003/

*** First, I would argue that we do not want to test
"native" modes (ex: codec, scanline, etc) to scales
that require sampling (ex: 0.1, 0.2, etc).  Right now,
we are trying to scale jpegs to 0.1, settling for 0.125
as the closest option, and then trying to compare the
0.125 scaled image to the actual 0.1 scaled image in
Gold.

*** Second, I messed up and caused our test setup to
try to decode to kIndex8 and kGray8 "always" instead
of only when it is recommended.  The bad effect of this
happens because we can decode jpegs to kGray8 even if
they are color images.  Right now in Gold, we have a
bunch of untriaged gray versions of color images.

The second issue would have been caught if we signaled
a fatal failure for invalid conversions.  Maybe we should
look into this now that 565 is supported everywhere?

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/36c3796fbf6df5f1253f6ce48fb74a6d72f79bae

[msarett, 2015-09-02 14:15:24]

msarett@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2015-09-02 15:54:16]

> The second issue would have been caught if we signaled
> a fatal failure for invalid conversions.  Maybe we should
> look into this now that 565 is supported everywhere?

Agreed.

https://codereview.chromium.org/1314163007/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1314163007/diff/1/dm/DM.cpp#newcode269
dm/DM.cpp:269: // SkScaledCodec Scales
I think it would make more sense to move the SkScaledCodec scales (and modes)
down to where they are used.

https://codereview.chromium.org/1314163007/diff/1/dm/DM.cpp#newcode326
dm/DM.cpp:326: for (CodecSrc::Mode mode : samplingModes) {
There is only one mode in samplingModes. Would it make more sense to remove this
loop? Or do you think we'll add more modes in the future?

[msarett, 2015-09-02 18:16:16]

https://codereview.chromium.org/1314163007/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1314163007/diff/1/dm/DM.cpp#newcode269
dm/DM.cpp:269: // SkScaledCodec Scales
On 2015/09/02 15:54:16, scroggo wrote:
> I think it would make more sense to move the SkScaledCodec scales (and modes)
> down to where they are used.

Done.

https://codereview.chromium.org/1314163007/diff/1/dm/DM.cpp#newcode326
dm/DM.cpp:326: for (CodecSrc::Mode mode : samplingModes) {
On 2015/09/02 15:54:16, scroggo wrote:
> There is only one mode in samplingModes. Would it make more sense to remove
this
> loop? Or do you think we'll add more modes in the future?

I think we may want to add a mode when we add subsetting to SkScaledCodec.  But
I think it's better to not over-prepare.  We can add the loop back later if we
need it.

[scroggo, 2015-09-02 19:47:58]

lgtm

[msarett, 2015-09-02 20:15:33]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2015-09-02 20:15:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314163007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314163007/40001

[commit-bot: I haz the power, 2015-09-02 20:20:55]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/36c3796fbf6df5f1253f6ce48fb74a6d72f79bae