Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1314163005: Move loader stub libraries out of //build/config/linux (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move loader stub libraries out of //build/config/linux The //build/config/linux library defined a number of targets built through the generate_library_loader target. All of these are fairly chrome-specific, so having them defined in the //build/config/linux file made it harder to reuse that file in non-chrome GN builds (like native_client). This CL moves the targets out to a new //build/linux directory and updates the callers accordingly. R=brettw@chromium.org BUG= Committed: https://crrev.com/ad0c1f495eca0968601ea74254b86fb91d412eb0 Cr-Commit-Position: refs/heads/master@{#346242}

Patch Set 1 #

Patch Set 2 : add missing libusb file #

Patch Set 3 : fix exec_script() whitelist #

Patch Set 4 : fix libbrl references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -108 lines) Patch
M .gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 2 chunks +0 lines, -99 lines 0 comments Download
A build/linux/BUILD.gn View 1 chunk +105 lines, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M device/udev_linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libusb/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
Dirk Pranke
5 years, 3 months ago (2015-08-28 01:57:36 UTC) #1
brettw
lgtm
5 years, 3 months ago (2015-08-28 17:46:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314163005/20001
5 years, 3 months ago (2015-08-28 18:13:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/75358) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-08-28 18:18:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314163005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314163005/40001
5 years, 3 months ago (2015-08-28 18:58:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/75389)
5 years, 3 months ago (2015-08-28 19:05:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314163005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314163005/60001
5 years, 3 months ago (2015-08-28 20:42:58 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-28 21:48:09 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 21:49:21 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ad0c1f495eca0968601ea74254b86fb91d412eb0
Cr-Commit-Position: refs/heads/master@{#346242}

Powered by Google App Engine
This is Rietveld 408576698