Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Issue 1314163003: [turbofan] Ensure stackcheck flags do something. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure stackcheck flags do something. While the intention is to eventually do away with FLAG_turbo_loop_stackcheck and FLAG_turbo_preprocess_range, they are useful for the interim we are still testing and benchmarking the feature. Committed: https://crrev.com/283d41372936855934e30b6175b933822cc951ea Cr-Commit-Position: refs/heads/master@{#30399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-27 00:46:10 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-08-27 04:36:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314163003/1
5 years, 3 months ago (2015-08-27 04:40:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 04:41:26 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 04:41:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/283d41372936855934e30b6175b933822cc951ea
Cr-Commit-Position: refs/heads/master@{#30399}

Powered by Google App Engine
This is Rietveld 408576698