Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1314153006: Moved committer list to chrome-infra-auth and deleted it from the repo (Closed)

Created:
5 years, 3 months ago by Sergiy Byelozyorov
Modified:
5 years, 3 months ago
Reviewers:
rmistry, rmistry1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git/@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Moved committer list to chrome-infra-auth and deleted it from the repo R=rmistry@chromium.org BUG=chromium:511311 Committed: https://skia.googlesource.com/skia/+/613f20aa4b93c9196680608531b5496ec97dd090

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Patch Set 3 : Remove unneeded preposition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -50 lines) Patch
M CQ_COMMITTERS View 1 chunk +2 lines, -47 lines 0 comments Download
M infra/branch-config/cq.cfg View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Sergiy Byelozyorov
5 years, 3 months ago (2015-09-01 21:36:35 UTC) #1
rmistry
https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS File CQ_COMMITTERS (right): https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS#newcode2 CQ_COMMITTERS:2: https://chrome-infra-auth.appspot.com/auth/groups#project-skia-committers. This messaging is very helpful. Thanks! I just ...
5 years, 3 months ago (2015-09-02 11:13:17 UTC) #3
Sergiy Byelozyorov
https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS File CQ_COMMITTERS (right): https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS#newcode2 CQ_COMMITTERS:2: https://chrome-infra-auth.appspot.com/auth/groups#project-skia-committers. On 2015/09/02 11:13:17, rmistry wrote: > This messaging ...
5 years, 3 months ago (2015-09-02 17:31:17 UTC) #4
rmistry
On 2015/09/02 17:31:17, Sergiy Byelozyorov wrote: > https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS > File CQ_COMMITTERS (right): > > https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS#newcode2 ...
5 years, 3 months ago (2015-09-02 18:53:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314153006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314153006/40001
5 years, 3 months ago (2015-09-02 20:32:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314153006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314153006/40001
5 years, 3 months ago (2015-09-02 20:33:44 UTC) #10
rmistry
On 2015/09/02 18:53:04, rmistry wrote: > On 2015/09/02 17:31:17, Sergiy Byelozyorov wrote: > > https://codereview.chromium.org/1314153006/diff/1/CQ_COMMITTERS ...
5 years, 3 months ago (2015-09-02 20:36:28 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/613f20aa4b93c9196680608531b5496ec97dd090
5 years, 3 months ago (2015-09-02 20:37:56 UTC) #12
Sergiy Byelozyorov
5 years, 3 months ago (2015-09-02 20:39:34 UTC) #13
Message was sent while issue was closed.
On 2015/09/02 18:53:04, rmistry wrote:
> We should probably wait for the config change discussed in the other thread to
> be resolved before submitting this. Otherwise luci-config will not be able to
> read cq.cfg and the existing CQ_COMMITTERS file will be empty causing the
> current CQ to get an empty list.

This should be already fixed because I've deployed a new version of the app.

Powered by Google App Engine
This is Rietveld 408576698