Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1314133005: Revert of Remove RenderFrameMessageFilter. (Closed)

Created:
5 years, 3 months ago by Avi (use Gerrit)
Modified:
5 years, 3 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove RenderFrameMessageFilter. (patchset #1 id:1 of https://codereview.chromium.org/1324803002/ ) Reason for revert: We're going a different route. Original issue's description: > Remove RenderFrameMessageFilter. > > All the conversions to frame IPCs are happening on RenderMessageFilter, anyway. > > BUG=none > TEST=none > > Committed: https://crrev.com/8acbcea784e3aa4cbfc500a08ae0344fafb32289 > Cr-Commit-Position: refs/heads/master@{#346675} TBR=creis@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/2dfabeace351e55a8a3f0ec8c83490dea83b4f37 Cr-Commit-Position: refs/heads/master@{#346721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -42 lines) Patch
A content/browser/frame_host/render_frame_message_filter.h View 1 chunk +45 lines, -0 lines 0 comments Download
A content/browser/frame_host/render_frame_message_filter.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M content/browser/renderer_host/DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +0 lines, -32 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Remove RenderFrameMessageFilter.
5 years, 3 months ago (2015-09-01 20:17:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314133005/1
5 years, 3 months ago (2015-09-01 20:17:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 20:18:14 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 20:18:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dfabeace351e55a8a3f0ec8c83490dea83b4f37
Cr-Commit-Position: refs/heads/master@{#346721}

Powered by Google App Engine
This is Rietveld 408576698