internal: setup skfe internal.skia.org

internal: setup skfe internal.skia.org

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/4f1ab9c2ecc2c69dcbb80a0c6cc2e96ea88132b5

[jcgregorio, 2015-08-27 14:23:27]

jcgregorio@google.com changed reviewers:
+ stephana@google.com

[stephana, 2015-08-27 14:31:33]

lgtm with one comment about the if statement. 
We can leave it for now and clean up later.

https://codereview.chromium.org/1314133003/diff/1/skfe/sys/skia_org_nginx
File skfe/sys/skia_org_nginx (right):

https://codereview.chromium.org/1314133003/diff/1/skfe/sys/skia_org_nginx#new...
skfe/sys/skia_org_nginx:461: if ( $host != 'internal.skia.org' ) {
This if block should not be necessary (here or most of the other servers
defined). IIRC this was put for the case where we have two host names in the
same server definition and we want to redirect to the canonical host.

[jcgregorio, 2015-08-27 14:33:32]

https://codereview.chromium.org/1314133003/diff/1/skfe/sys/skia_org_nginx
File skfe/sys/skia_org_nginx (right):

https://codereview.chromium.org/1314133003/diff/1/skfe/sys/skia_org_nginx#new...
skfe/sys/skia_org_nginx:461: if ( $host != 'internal.skia.org' ) {
On 2015/08/27 at 14:31:32, stephana wrote:
> This if block should not be necessary (here or most of the other servers
defined). IIRC this was put for the case where we have two host names in the
same server definition and we want to redirect to the canonical host.

Done.

[jcgregorio, 2015-08-27 14:33:33]

The CQ bit was checked by jcgregorio@google.com

[jcgregorio, 2015-08-27 14:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from stephana@google.com
Link to the patchset: https://codereview.chromium.org/1314133003/#ps20001
(title: "clean")

[commit-bot: I haz the power, 2015-08-27 14:33:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314133003/20001

[commit-bot: I haz the power, 2015-08-27 14:34:48]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/4f1ab9c2ecc2c69dcbb80a0c6cc2e96ea881...