Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1314123005: [Android] Minor fixes for device_status_check. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Minor fixes for device_status_check. This includes: - catching IOError on failure to reset USB - adding newlines to the bot status output BUG= Committed: https://crrev.com/46e0c7d3fd1f7a484f6319240f120378b4c48cd3 Cr-Commit-Position: refs/heads/master@{#347713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 3 months ago (2015-09-08 14:52:18 UTC) #2
rnephew (Reviews Here)
On 2015/09/08 14:52:18, jbudorick wrote: lgtm
5 years, 3 months ago (2015-09-08 14:56:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314123005/1
5 years, 3 months ago (2015-09-08 15:02:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 16:21:15 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 16:22:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46e0c7d3fd1f7a484f6319240f120378b4c48cd3
Cr-Commit-Position: refs/heads/master@{#347713}

Powered by Google App Engine
This is Rietveld 408576698