LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html - Issue 1314123002: Remove hard-coded origins in layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html

Issue 1314123002: Remove hard-coded origins in layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix fetch(...) tests relying on hard-coded origins. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker-proxied.html ('K') | « LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-base-https-other-https.html ('k') | LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors-base-https-other-https.html » ('j') | LayoutTests/http/tests/serviceworker/resources/test-helpers.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html

diff --git a/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html b/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html

index 7b15d9dcd84d22fed1f8ca8a5c9c1a0bcf480129..9aca557da2b0c95158dbbb75a299bd83d9e7484f 100644

--- a/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html

+++ b/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/auth-nocors.html

@@ -3,6 +3,7 @@

+<script src = "/resources/get-host-info.js"></script>

@@ -16,13 +17,17 @@ function onlyOnServiceWorkerProxiedTest(checkFuncs) {

</head>

<body>

+var host_info = get_host_info();

function start(t) {

executeServiceWorkerProxiedTests(TEST_TARGETS);

t.done();

}

function init(test) {

- return login(test)

- .then(function() {return login_https(test);});

+ return login(host_info["HTTP_ORIGIN"], host_info["HTTP_REMOTE_ORIGIN"], test)

+ .then(function() {

+ return login(host_info["HTTPS_ORIGIN"],

+ host_info["HTTPS_REMOTE_ORIGIN"], test);

+ });

}

</script>