LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html - Issue 1314123002: Remove hard-coded origins in layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html

Issue 1314123002: Remove hard-coded origins in layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix fetch(...) tests relying on hard-coded origins. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker-proxied.html » ('j') | LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker-proxied.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html

diff --git a/LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html b/LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html

index 6d7e952838e929c5a55bf3a26f0e9cafdb48e4d0..b942706d31645bcc585bd46ccc5b09fcacf9c987 100644

--- a/LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html

+++ b/LayoutTests/http/tests/fetch/script-tests/thorough/TEMPLATE-serviceworker.html

@@ -3,10 +3,12 @@

+<script src = "/resources/get-host-info.js?pipe=sub"></script>

</head>

<body>

+var host_info = get_host_info();

function start(t) {

service_worker_test(

'/fetch/script-tests/thorough/TESTNAME.js?OPTIONS',

@@ -14,8 +16,10 @@ function start(t) {

t.done();

}

function init(test) {

- return login(test)

- .then(function() {return login_https(test);});

+ return login(host_info['HTTP_ORIGIN'], host_info['HTTP_REMOTE_ORIGIN'], test)

+ .then(function() {

+ return login(host_info['HTTPS_ORIGIN'], host_info['HTTPS_REMOTE_ORIGIN'],

+ test);});

}

</script>