Use Instant suggested match type for Instant temporary text.

chrome/browser/ui/omnibox/omnibox_edit_model.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/format_macros.h"
@@ skipping 531 matching lines @@
   return AutocompleteMatch::IsSearchType(match.type);
 }
 
 void OmniboxEditModel::AcceptInput(WindowOpenDisposition disposition,
                                    bool for_drop) {
   // Get the URL and transition type for the selected entry.
   AutocompleteMatch match;
   GURL alternate_nav_url;
   GetInfoForCurrentText(&match, &alternate_nav_url);
 
+  // If Instant provided the current match, let it decide whether it should be
+  // treated as a navigation or search. http://crbug.com/224522.
+  if (is_temporary_text_set_by_instant_)
+    match.transition = content::PAGE_TRANSITION_GENERATED;

[Peter Kasting, 2013/03/28 20:35:00]

It's not at all clear to me why this fixes the problem you're having.

The comment here needs to be filled out to describe precisely what this is doing
and why it should be here, as well as why having Instant set the transition type
correctly itself doesn't make sense, and how the proper transition type is going
to be set after this.

Also, don't refer to bugs in comments.  The comment should tell the reader
everything they need to know.

+
   // If CTRL is down it means the user wants to append ".com" to the text he
   // typed. If we can successfully generate a URL_WHAT_YOU_TYPED match doing
   // that, then we use this.
   if (control_key_state_ == DOWN_WITHOUT_CHANGE && !KeywordIsSelected()) {
     // Generate a new AutocompleteInput, copying the latest one but using "com"
     // as the desired TLD. Then use this autocomplete input to generate a
     // URL_WHAT_YOU_TYPED AutocompleteMatch. Note that using the most recent
     // input instead of the currently visible text means we'll ignore any
     // visible inline autocompletion: if a user types "foo" and is autocompleted
     // to "foodnetwork.com", ctrl-enter will  navigate to "foo.com", not
@@ skipping 821 matching lines @@
     instant->OmniboxFocusChanged(state, reason, NULL);
 
   // Update state and notify view if the omnibox has focus and the caret
   // visibility changed.
   const bool was_caret_visible = is_caret_visible();
   focus_state_ = state;
   if (focus_state_ != OMNIBOX_FOCUS_NONE &&
       is_caret_visible() != was_caret_visible)
     view_->ApplyCaretVisibility();
 }