Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: util/win/exception_handler_server.h

Issue 1314093002: Refactor handler/main for Windows, implement CrashHandlerExceptionServer (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe
Patch Set: fixes2 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/process_snapshot_win.cc ('k') | util/win/exception_handler_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/exception_handler_server.h
diff --git a/util/win/exception_handler_server.h b/util/win/exception_handler_server.h
index 42642f557c1d2cda7ac351372fcc019109cc4b70..fd943acddbbe769251e510ab1854ff2d7f012e14 100644
--- a/util/win/exception_handler_server.h
+++ b/util/win/exception_handler_server.h
@@ -57,18 +57,16 @@ class ExceptionHandlerServer {
};
//! \brief Constructs the exception handling server.
- //!
- //! \param[in] delegate The interface to which the exceptions are delegated
- //! when they are caught in Run(). Ownership is not transferred and it
- //! must outlive this object.
- explicit ExceptionHandlerServer(Delegate* delegate);
+ ExceptionHandlerServer();
~ExceptionHandlerServer();
//! \brief Runs the exception-handling server.
//!
+ //! \param[in] delegate The interface to which the exceptions are delegated
+ //! when they are caught in Run(). Ownership is not transferred.
//! \param[in] pipe_name The name of the pipe to listen on. Must be of the
//! form "\\.\pipe\<some_name>".
- void Run(const std::string& pipe_name);
+ void Run(Delegate* delegate, const std::string& pipe_name);
//! \brief Stops the exception-handling server. Returns immediately. The
//! object must not be destroyed until Run() returns.
@@ -81,7 +79,6 @@ class ExceptionHandlerServer {
static void __stdcall OnDumpEvent(void* ctx, BOOLEAN);
static void __stdcall OnProcessEnd(void* ctx, BOOLEAN);
- Delegate* delegate_; // Weak.
ScopedKernelHANDLE port_;
base::Lock clients_lock_;
« no previous file with comments | « snapshot/win/process_snapshot_win.cc ('k') | util/win/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698