handler/crashpad_handler.ad - Issue 1314093002: Refactor handler/main for Windows, implement CrashHandlerExceptionServer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: handler/crashpad_handler.ad

Issue 1314093002: Refactor handler/main for Windows, implement CrashHandlerExceptionServer (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe

Patch Set: fixes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: handler/crashpad_handler.ad

diff --git a/handler/mac/crashpad_handler.ad b/handler/crashpad_handler.ad

similarity index 94%

rename from handler/mac/crashpad_handler.ad

rename to handler/crashpad_handler.ad

index b53d097711431776f694d266521df4ea2c9ff166..d7ad919dd7b15738269d71c4748a03efa4ef9726 100644

--- a/handler/mac/crashpad_handler.ad

+++ b/handler/crashpad_handler.ad

@@ -75,7 +75,12 @@ of 'PATH' exists.

*--handshake-fd*='FD'::

Perform the handshake with the initial client on the file descriptor at 'FD'.

-This option is required.

+This option is required. This option is only valid on Mac.

Mark Mentovai 2015/09/03 20:07:29 Mac OS X in formal documentation, or just OS X (wh

scottmg 2015/09/03 20:30:01 Done.

+*--pipe-name*='PIPE'::

+Listen on the given pipe name for connections from clients. 'PIPE' must be of

+the form \\.\pipe\<somename>. This option is required. This option is only valid

Mark Mentovai 2015/09/03 20:07:29 Put + signs around this like +\\.\pipe\<somename>+

scottmg 2015/09/03 20:30:01 Done.

+on Windows.

*--url*='URL'::

If uploads are enabled, sends crash reports to the Breakpad-type crash report

« no previous file with comments | « no previous file | handler/handler.gyp » ('j') | handler/win/crash_report_exception_handler.cc » ('J')