Refactor handler/main for Windows, implement CrashHandlerExceptionServer

handler/win/crash_report_exception_handler.cc

Index: handler/win/crash_report_exception_handler.cc
diff --git a/handler/win/crash_report_exception_handler.cc b/handler/win/crash_report_exception_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ffad8205c2f153925d2a7ef62e03ecd427d28d44
--- /dev/null
+++ b/handler/win/crash_report_exception_handler.cc
@@ -0,0 +1,131 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "handler/win/crash_report_exception_handler.h"
+
+#include "client/crash_report_database.h"
+#include "client/settings.h"
+#include "handler/crash_report_upload_thread.h"
+#include "minidump/minidump_file_writer.h"
+#include "snapshot/win/process_reader_win.h"
+#include "snapshot/win/process_snapshot_win.h"
+#include "util/file/file_writer.h"
+#include "util/win/registration_protocol_win.h"
+
+namespace crashpad {
+
+CrashReportExceptionHandler::CrashReportExceptionHandler(
+    CrashReportDatabase* database,
+    CrashReportUploadThread* upload_thread,
+    const std::map<std::string, std::string>* process_annotations)
+    : database_(database),
+      upload_thread_(upload_thread),
+      process_annotations_(process_annotations) {
+}
+
+CrashReportExceptionHandler::~CrashReportExceptionHandler() {
+}
+
+void CrashReportExceptionHandler::ExceptionHandlerServerStarted() {
+}
+
+unsigned int CrashReportExceptionHandler::ExceptionHandlerServerException(
+    HANDLE process,
+    WinVMAddress exception_information_address) {
+  const unsigned int kFailedTerminationCode = 0xffff7002;
+  ProcessReaderWin process_reader;
+  if (!process_reader.Initialize(process)) {
+    LOG(WARNING) << "ProcessReaderWin Initialize failed";
+    return kFailedTerminationCode;
+  }
+  ExceptionInformation exception_information;
+  if (!process_reader.ReadMemory(exception_information_address,
+                                 sizeof(exception_information),
+                                 &exception_information)) {
+    LOG(WARNING) << "ReadMemory ExceptionInformation failed";
+    return kFailedTerminationCode;
+  }
+
+  // TODO(scottmg): ScopedProcessSuspend
+
+  ProcessSnapshotWin process_snapshot;
+  if (!process_snapshot.Initialize(process)) {

[Mark Mentovai, 2015/09/03 18:33:37]

ProcessSnapshotWin is going to make a ProcessReader, but you just made one to
read the ExceptionInformation struct, and now that original ProcessReader is
going to go to waste. There are a few ways to fix this, do you want to clean it
up?

[scottmg, 2015/09/03 19:54:31]

Done.

+    LOG(WARNING) << "ProcessSnapshotWin Initialize failed";

[Mark Mentovai, 2015/09/03 18:33:37]

You can use :: here, and you can say ProcessSnapshotWin::InitializeException on
line 71.

[scottmg, 2015/09/03 19:54:31]

Done.

+    return kFailedTerminationCode;
+  }
+
+  if (!process_snapshot.InitializeException(
+          exception_information.thread_id,
+          exception_information.exception_pointers)) {
+    LOG(WARNING) << "InitializeException failed";
+    return kFailedTerminationCode;
+  }
+
+  // Now that we have the exception information, even if something else fails we
+  // can terminate the process with the correct exit code.
+  unsigned int termination_code = process_snapshot.Exception()->Exception();

[Mark Mentovai, 2015/09/03 18:33:37]

OK, but not required, to be const. (I’m trying to use const more frequently for
more than just traditional kConstants to prevent accidental modification.)

[scottmg, 2015/09/03 19:54:31]

Done.

+
+  CrashpadInfoClientOptions client_options;
+  process_snapshot.GetCrashpadOptions(&client_options);
+  if (client_options.crashpad_handler_behavior != TriState::kDisabled) {
+    UUID client_id;
+    Settings* const settings = database_->GetSettings();
+    if (settings) {
+      // If GetSettings() or GetClientID() fails, something else will log a
+      // message and client_id will be left at its default value, all zeroes,
+      // which is appropriate.
+      settings->GetClientID(&client_id);
+    }
+
+    process_snapshot.SetClientID(client_id);
+    process_snapshot.SetAnnotationsSimpleMap(*process_annotations_);
+
+    CrashReportDatabase::NewReport* new_report;
+    CrashReportDatabase::OperationStatus database_status =
+        database_->PrepareNewCrashReport(&new_report);
+    if (database_status != CrashReportDatabase::kNoError) {
+      LOG(ERROR) << "PrepareNewCrashReport failed";
+      return termination_code;
+    }
+
+    process_snapshot.SetReportID(new_report->uuid);
+
+    CrashReportDatabase::CallErrorWritingCrashReport
+        call_error_writing_crash_report(database_, new_report);
+
+    WeakFileHandleFileWriter file_writer(new_report->handle);
+
+    MinidumpFileWriter minidump;
+    minidump.InitializeFromSnapshot(&process_snapshot);
+    if (!minidump.WriteEverything(&file_writer)) {
+      LOG(ERROR) << "WriteEverything failed";
+      return termination_code;
+    }
+
+    call_error_writing_crash_report.Disarm();
+
+    UUID uuid;
+    database_status = database_->FinishedWritingCrashReport(new_report, &uuid);
+    if (database_status != CrashReportDatabase::kNoError) {
+      LOG(ERROR) << "FinishedWritingCrashReport failed";
+      return termination_code;
+    }
+
+    upload_thread_->ReportPending();
+  }
+
+  return termination_code;
+}
+
+}  // namespace crashpad