Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: handler/handler.gyp

Issue 1314093002: Refactor handler/main for Windows, implement CrashHandlerExceptionServer (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe
Patch Set: debase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | handler/mac/main.cc » ('j') | handler/main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/handler.gyp
diff --git a/handler/handler.gyp b/handler/handler.gyp
index 33c7fd5bc3be56eeee99b30e0f7376cf39e69d1b..03d90b7c3a7a80e81c968598c3ed62104ff94dfc 100644
--- a/handler/handler.gyp
+++ b/handler/handler.gyp
@@ -42,7 +42,7 @@
'mac/crash_report_exception_handler.h',
'mac/exception_handler_server.cc',
'mac/exception_handler_server.h',
- 'mac/main.cc',
+ 'main.cc',
],
# In an in-Chromium build with component=shared_library,
@@ -73,11 +73,12 @@
'targets': [
{
'target_name': 'crashpad_handler',
Mark Mentovai 2015/09/03 18:33:37 Can we share this target between mac and win now?
scottmg 2015/09/03 19:54:31 Indeed, and that fixes some missing dependencies.
- # TODO(scottmg): This will soon be an executable, once main.cc exists.
- 'type': 'static_library',
+ 'type': 'executable',
'dependencies': [
'../compat/compat.gyp:crashpad_compat',
+ '../minidump/minidump.gyp:crashpad_minidump',
'../third_party/mini_chromium/mini_chromium.gyp:base',
+ '../tools/tools.gyp:crashpad_tool_support',
'../util/util.gyp:crashpad_util',
],
'include_dirs': [
@@ -86,6 +87,24 @@
'sources': [
'crash_report_upload_thread.cc',
'crash_report_upload_thread.h',
+ 'win/crash_report_exception_handler.cc',
+ 'win/crash_report_exception_handler.h',
+ 'main.cc',
+ ],
+ },
+ {
+ 'target_name': 'crashy_program',
+ 'type': 'executable',
+ 'dependencies': [
+ '../client/client.gyp:crashpad_client',
+ '../third_party/mini_chromium/mini_chromium.gyp:base',
+ '../tools/tools.gyp:crashpad_tool_support',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ 'sources': [
+ 'win/crashy_test_program.cc',
],
},
],
« no previous file with comments | « no previous file | handler/mac/main.cc » ('j') | handler/main.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698