Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1314063004: Attempt base cleanup from DEPS. (Closed)

Created:
5 years, 3 months ago by Eran Messeri
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, Cait (Slow)
CC:
chromium-reviews, tracing+reviews_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, wfh+watch_chromium.org, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup explicit base dependency from DEPS files of all components that had it. According to thestig@ the explicit dependency is unnecessary. BUG= Committed: https://crrev.com/79db44aa3aac91cc23dfe609a0df9742e78812ad Cr-Commit-Position: refs/heads/master@{#347403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M components/html_viewer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/memory_pressure/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/message_port/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/packed_ct_ev_whitelist/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/rlz/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_json/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/tracing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/update_client/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/wallpaper/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Eran Messeri
Cait - a small cleanup for you to review.
5 years, 3 months ago (2015-09-03 20:21:04 UTC) #2
Lei Zhang
For reference, see the "include_rules" section in the top-level DEPS file.
5 years, 3 months ago (2015-09-03 20:24:34 UTC) #4
Cait (Slow)
LGTM Note that we do use the include_rules to specify dependencies besides other components (such ...
5 years, 3 months ago (2015-09-04 14:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314063004/1
5 years, 3 months ago (2015-09-04 14:40:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 14:45:25 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 14:46:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79db44aa3aac91cc23dfe609a0df9742e78812ad
Cr-Commit-Position: refs/heads/master@{#347403}

Powered by Google App Engine
This is Rietveld 408576698