Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1314053002: Have GPUTracer process traces during CommandBuffer Idle time. (Closed)

Created:
5 years, 4 months ago by David Yen
Modified:
5 years, 3 months ago
Reviewers:
Zhenyao Mo, vmiura
CC:
chromium-reviews, piman+watch_chromium.org, Shouqun1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have GPUTracer process traces during CommandBuffer Idle time. ThreadTaskRunnerHandle is not always available to execute GPUTracer process commands (IE on android webview), switch to use the command buffer idle time instead. R=vmiura@chromium.org BUG=None TEST=trybots Committed: https://crrev.com/ed04ca3ef4560f5d85d4ee788e6716d37c7be644 Cr-Commit-Position: refs/heads/master@{#345672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -61 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_tracer.h View 3 chunks +3 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 6 chunks +28 lines, -47 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 6 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
David Yen
5 years, 4 months ago (2015-08-25 23:15:03 UTC) #1
boliu
> ThreadTaskRunnerHandle is not always available to execute GPUTracer process commands ie on android webview..
5 years, 4 months ago (2015-08-25 23:35:39 UTC) #2
David Yen
On 2015/08/25 23:35:39, boliu wrote: > > ThreadTaskRunnerHandle is not always available to execute GPUTracer ...
5 years, 4 months ago (2015-08-25 23:37:23 UTC) #3
David Yen
+zmo for review in case vmiura is busy
5 years, 4 months ago (2015-08-25 23:38:11 UTC) #5
vmiura
lgtm
5 years, 3 months ago (2015-08-26 20:54:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314053002/1
5 years, 3 months ago (2015-08-26 20:57:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 21:05:09 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 21:06:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed04ca3ef4560f5d85d4ee788e6716d37c7be644
Cr-Commit-Position: refs/heads/master@{#345672}

Powered by Google App Engine
This is Rietveld 408576698