Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/core/editing/VisiblePosition.h

Issue 1314033005: Move canonicalPosition() for VisiblePosition to VisibleUnits.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T14:49:27 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // TODO(yosin) We should move a glboal funciton 121 // TODO(yosin) We should move a glboal funciton
122 // |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h" 122 // |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h"
123 // as static function. 123 // as static function.
124 int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&); 124 int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&);
125 125
126 // TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to 126 // TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
127 // "VisibleUnits.cpp". 127 // "VisibleUnits.cpp".
128 VisiblePosition leftPositionOf(const VisiblePosition&); 128 VisiblePosition leftPositionOf(const VisiblePosition&);
129 VisiblePosition rightPositionOf(const VisiblePosition&); 129 VisiblePosition rightPositionOf(const VisiblePosition&);
130 130
131 CORE_EXPORT Position canonicalPositionOf(const Position&);
132 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&);
133
134 // TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to 131 // TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to
135 // "VisibleUnits.cpp" as static function. 132 // "VisibleUnits.cpp" as static function.
136 // next() and previous() will increment/decrement by a character cluster. 133 // next() and previous() will increment/decrement by a character cluster.
137 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Pos ition& anchor); 134 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Pos ition& anchor);
138 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor); 135 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor);
139 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const Positi onInComposedTreeWithAffinity&, const PositionInComposedTree& anchor); 136 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const Positi onInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
140 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Posi tion& anchor); 137 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Posi tion& anchor);
141 138
142 CORE_EXPORT VisiblePosition visiblePositionOf(const Position&, TextAffinity = VP _DEFAULT_AFFINITY); 139 CORE_EXPORT VisiblePosition visiblePositionOf(const Position&, TextAffinity = VP _DEFAULT_AFFINITY);
143 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionWithAffinity&); 140 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionWithAffinity&);
144 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionInComposedTree&, Tex tAffinity = VP_DEFAULT_AFFINITY); 141 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionInComposedTree&, Tex tAffinity = VP_DEFAULT_AFFINITY);
145 142
146 } // namespace blink 143 } // namespace blink
147 144
148 #ifndef NDEBUG 145 #ifndef NDEBUG
149 // Outside the WebCore namespace for ease of invocation from gdb. 146 // Outside the WebCore namespace for ease of invocation from gdb.
150 void showTree(const blink::VisiblePosition*); 147 void showTree(const blink::VisiblePosition*);
151 void showTree(const blink::VisiblePosition&); 148 void showTree(const blink::VisiblePosition&);
152 #endif 149 #endif
153 150
154 #endif // VisiblePosition_h 151 #endif // VisiblePosition_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698