Issue 131403008: Revert of Use removeFontFace to avoid resetting fontSelector.

Issue 131403008: Revert of Use removeFontFace to avoid resetting fontSelector. (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Kunihiko Sakamoto, esprehn, tasak, dglazkov, ojan

CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/82583005/ Reason for revert: This broke PrintWebViewHelperTest.PrintLayoutTest on Mac TBR=ksakamoto@chromium.org,esprehn@chromium.org,ojan@chromium.org,dglazkov@chromium.org,tasak@google.com NOTREECHECKS=true NOTRY=true BUG=305885 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164783

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -241 lines)			Patch
D	LayoutTests/fast/css/cssom-modify-font-face-rule.html	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	LayoutTests/fast/css/cssom-modify-font-face-rule-expected.html	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	LayoutTests/fast/css/font-face-insertBefore.html	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	LayoutTests/fast/css/font-face-insertBefore-expected.html	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	Source/core/css/StyleSheetContents.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/css/StyleSheetContents.cpp	View	4 chunks	+3 lines, -47 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	Source/core/dom/StyleEngine.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/StyleEngine.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/StyleSheetCollection.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/dom/StyleSheetCollection.cpp	View	2 chunks	+27 lines, -14 lines	0 comments	Download
M	Source/core/frame/Settings.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	Source/core/frame/Settings.cpp	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	Source/core/frame/SettingsDelegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/Page.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/testing/InternalSettings.cpp	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/platform/fonts/FontDescription.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Created Revert of Use removeFontFace to avoid resetting fontSelector.

6 years, 11 months ago (2014-01-09 15:41:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/131403008/1

6 years, 11 months ago (2014-01-09 15:41:52 UTC) #2

Message was sent while issue was closed.

Change committed as 164783

Expand Messages | Collapse Messages