[Retry] PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation

[Retry] PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation

Original Review: https://codereview.chromium.org/113363004/

Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
the given path. This makes it difficult to create POSIX compatible API on
top of PPAPI.

This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
That makes a new directory according to the given PP_MakeDirectoryFlags
values. The flags provide exclusive operation option. If exclusive flag
is specified and a directory exists on the given path, the function fails
and returns PP_ERROR_FILEEXISTS.


BUG=314879
TEST=browser_tests
TBR=dmichael@chromium.org,yzshen@chromium.org,tsepez@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244148

[nhiroki, 2014-01-09 16:39:31]

Hi binji@,

Can you review native_client_sdk/* ?
Other parts got owner stamps in the original review,
but I forgot to change the NaCl SDK part...

Thanks!

[binji, 2014-01-09 18:28:12]

native_client_sdk lgtm, thanks!

[nhiroki, 2014-01-10 00:38:21]

TBRing to original reviewers (dmichael@, yzshen@ and tsepez@).
There is no difference from the original review except the NaCl SDK part.

Thanks!

[commit-bot: I haz the power, 2014-01-10 00:44:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/131403004/40024

[commit-bot: I haz the power, 2014-01-10 03:36:38]

Failed to apply patch for ppapi/thunk/interfaces_ppb_public_dev_channel.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ppapi/thunk/interfaces_ppb_public_dev_channel.h
  Hunk #1 FAILED at 8.
  1 out of 1 hunk FAILED -- saving rejects to file
ppapi/thunk/interfaces_ppb_public_dev_channel.h.rej

Patch:       ppapi/thunk/interfaces_ppb_public_dev_channel.h
Index: ppapi/thunk/interfaces_ppb_public_dev_channel.h
diff --git a/ppapi/thunk/interfaces_ppb_public_dev_channel.h
b/ppapi/thunk/interfaces_ppb_public_dev_channel.h
index
a70442b945d7ae3cb25df78f37bd35f53e4dc105..43c16b5fc9f04c11a4847db51c8461c93a78bc54
100644
--- a/ppapi/thunk/interfaces_ppb_public_dev_channel.h
+++ b/ppapi/thunk/interfaces_ppb_public_dev_channel.h
@@ -8,5 +8,6 @@
 #include "ppapi/thunk/interfaces_preamble.h"
 
 // Interfaces go here.
+PROXIED_IFACE(PPB_FILEREF_INTERFACE_1_2, PPB_FileRef_1_2)
 
 #include "ppapi/thunk/interfaces_postamble.h"

[commit-bot: I haz the power, 2014-01-10 03:46:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/131403004/310001

[commit-bot: I haz the power, 2014-01-10 08:00:01]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-10 08:06:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/131403004/310001

[commit-bot: I haz the power, 2014-01-10 11:34:16]

Change committed as 244148