Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1314013007: Merge odd items and even items of FormDataList::m_items. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Merge odd items and even items of FormDataList::m_items. FormDataList::Item class represents a name string in a form data, or a value in a form data. A value can be a string or Blob, but a name string is always a string. Representing a name string by Item class is overkill. This CL adds m_key member to Item class. Odd items in FormDataList::m_items represented name strings, and even items in FormDataList::m_items represented values. Now each of items in FormDataList::m_items represents a pair of a name string and a value. This makes the code much simpler. This CL has no behavior changes. BUG=528840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -116 lines) Patch
M Source/core/html/FormDataList.h View 6 chunks +14 lines, -17 lines 0 comments Download
M Source/core/html/FormDataList.cpp View 8 chunks +52 lines, -93 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
5 years, 3 months ago (2015-09-07 07:24:51 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-09-07 07:28:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314013007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314013007/1
5 years, 3 months ago (2015-09-07 07:30:24 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 07:36:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201862

Powered by Google App Engine
This is Rietveld 408576698