gpu: Fix Vivante's "hisilicon" GPUs

content/common/gpu/image_transport_surface_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/image_transport_surface.h"
 
 #include "base/logging.h"
 #include "content/common/gpu/gpu_command_buffer_stub.h"
 #include "content/common/gpu/gpu_surface_lookup.h"
 #include "ui/gl/gl_surface_egl.h"
@@ skipping 11 matching lines @@
       GpuSurfaceLookup::GetInstance()->AcquireNativeWidget(
           stub->surface_id());
   scoped_refptr<gfx::GLSurface> surface =
       new gfx::NativeViewGLSurfaceEGL(false, window);
   bool initialize_success = surface->Initialize();
   if (window)
     ANativeWindow_release(window);
   if (!initialize_success)
     return scoped_refptr<gfx::GLSurface>();
 
+  if (stub->decoder()
+          ->GetContextGroup()
+          ->feature_info()
+          ->workarounds()
+          .makecurrent_recreates_surfaces) {

[no sievers, 2013/04/16 01:23:52]

Hmm, this is flaky as it depends on some other context in the share group
(ContextGroup) having been created before we create this surface for another
context, because the order is (from when I checked last):
1) create surface
2) create context
3) make context current for the first time
4) init decoder (which queries gl_vendor and stuff and sets workaround bits)

And this function is 1).

Can you call SetRecreateOnMakeCurrent() in GLES2DecoderImpl::Initialize?

[epennerAtGoogle, 2013/04/16 02:03:18]

I thought about that and it didn't appear to be a problem since the ContextGroup
is clearly created before all steps 1-4 above. Do you think the context group is
not initialized then?  I'll double check.

It's certainly nicer to call it here, since we know the type of surface and can
safely static_cast to the NativeViewGLSurfaceEGL.

[epennerAtGoogle, 2013/04/16 02:30:10]

You are right, the context-group might not be initialized, I'll do this in lower
in GpuCommandBufferStub::OnInitialize, since that is the function that created
the surface.

+    static_cast<gfx::NativeViewGLSurfaceEGL*>
+        (surface.get())->SetRecreateOnMakeCurrent(true);
+  }
+
   return scoped_refptr<gfx::GLSurface>(new PassThroughImageTransportSurface(
       manager, stub, surface.get(), false));
 }
 
 }  // namespace content