Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1313973005: Use a source_set instead of static_library for libdart_embedder_noio (Closed)

Created:
5 years, 3 months ago by jamesr
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use a source_set instead of static_library for libdart_embedder_noio Some linkers (like libtool) complain when trying to create a static_library with no sources. A source_set communicates the same thing to GN without upsetting the linker.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
5 years, 3 months ago (2015-09-10 00:56:33 UTC) #2
Cutch
lgtm but this is against a git mirror
5 years, 3 months ago (2015-09-10 14:13:13 UTC) #3
jamesr
On 2015/09/10 at 14:13:13, johnmccutchan wrote: > lgtm but this is against a git mirror ...
5 years, 3 months ago (2015-09-10 16:03:48 UTC) #4
Cutch
On 2015/09/10 16:03:48, jamesr wrote: > On 2015/09/10 at 14:13:13, johnmccutchan wrote: > > lgtm ...
5 years, 3 months ago (2015-09-10 16:32:55 UTC) #5
jamesr
5 years, 3 months ago (2015-09-10 16:35:49 UTC) #6
Message was sent while issue was closed.
On 2015/09/10 at 16:32:55, johnmccutchan wrote:
> On 2015/09/10 16:03:48, jamesr wrote:
> > On 2015/09/10 at 14:13:13, johnmccutchan wrote:
> > > lgtm but this is against a git mirror
> > 
> > I don't have push access anyway - could you land this for me?  ("git cl
patch"
> > doesn't care about the base url)
> 
> Done here- https://codereview.chromium.org/1331193002

Thanks!

Powered by Google App Engine
This is Rietveld 408576698