Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313953006: Never include ancestorLayer transform when testing for overlap. (Closed)

Created:
5 years, 3 months ago by chrishtr
Modified:
5 years, 3 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Never include ancestorLayer transform when testing for overlap. Also clean up unused option parameters to DPL::boundingBoxForCompositing. BUG=460195 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201324

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -33 lines) Patch
A LayoutTests/compositing/overlap-test-with-filter.html View 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/overlap-test-with-filter-expected.txt View 4 chunks +27 lines, -22 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 2 3 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chrishtr
https://codereview.chromium.org/1313953006/diff/1/LayoutTests/compositing/overlap-test-with-filter-expected.txt File LayoutTests/compositing/overlap-test-with-filter-expected.txt (right): https://codereview.chromium.org/1313953006/diff/1/LayoutTests/compositing/overlap-test-with-filter-expected.txt#newcode48 LayoutTests/compositing/overlap-test-with-filter-expected.txt:48: "bounds": [300, 100], This layer would be absent without ...
5 years, 3 months ago (2015-08-27 17:01:00 UTC) #2
Xianzhu
lgtm https://codereview.chromium.org/1313953006/diff/40001/Source/core/paint/DeprecatedPaintLayer.cpp File Source/core/paint/DeprecatedPaintLayer.cpp (right): https://codereview.chromium.org/1313953006/diff/40001/Source/core/paint/DeprecatedPaintLayer.cpp#newcode2145 Source/core/paint/DeprecatedPaintLayer.cpp:2145: // because those Layers don't paint into the ...
5 years, 3 months ago (2015-08-27 17:15:07 UTC) #3
chrishtr
https://codereview.chromium.org/1313953006/diff/40001/Source/core/paint/DeprecatedPaintLayer.cpp File Source/core/paint/DeprecatedPaintLayer.cpp (right): https://codereview.chromium.org/1313953006/diff/40001/Source/core/paint/DeprecatedPaintLayer.cpp#newcode2145 Source/core/paint/DeprecatedPaintLayer.cpp:2145: // because those Layers don't paint into the graphics ...
5 years, 3 months ago (2015-08-27 17:31:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313953006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313953006/60001
5 years, 3 months ago (2015-08-27 17:32:03 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 18:39:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201324

Powered by Google App Engine
This is Rietveld 408576698