Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 1313903003: [runtime] Remove the redundant %_IsObject intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Michis comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/lithium-codegen-arm64.cc
diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc
index 728f074a8a0b0dcb5a80c392c538ed37e60f0c0f..7cb6cb64bdd3b80ebb31a1be1b380891d7dc7039 100644
--- a/src/arm64/lithium-codegen-arm64.cc
+++ b/src/arm64/lithium-codegen-arm64.cc
@@ -3099,31 +3099,6 @@ void LCodeGen::DoIsConstructCallAndBranch(LIsConstructCallAndBranch* instr) {
}
-void LCodeGen::DoIsObjectAndBranch(LIsObjectAndBranch* instr) {
- Label* is_object = instr->TrueLabel(chunk_);
- Label* is_not_object = instr->FalseLabel(chunk_);
- Register value = ToRegister(instr->value());
- Register map = ToRegister(instr->temp1());
- Register scratch = ToRegister(instr->temp2());
-
- __ JumpIfSmi(value, is_not_object);
- __ JumpIfRoot(value, Heap::kNullValueRootIndex, is_object);
-
- __ Ldr(map, FieldMemOperand(value, HeapObject::kMapOffset));
-
- // Check for undetectable objects.
- __ Ldrb(scratch, FieldMemOperand(map, Map::kBitFieldOffset));
- __ TestAndBranchIfAnySet(scratch, 1 << Map::kIsUndetectable, is_not_object);
-
- // Check that instance type is in object type range.
- __ IsInstanceJSObjectType(map, scratch, NULL);
- // Flags have been updated by IsInstanceJSObjectType. We can now test the
- // flags for "le" condition to check if the object's type is a valid
- // JS object type.
- EmitBranch(instr, le);
-}
-
-
Condition LCodeGen::EmitIsString(Register input,
Register temp1,
Label* is_not_string,
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698