Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1313903003: [runtime] Remove the redundant %_IsObject intrinsic. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove the redundant %_IsObject intrinsic. %_IsObject(foo) is equivalent to typeof foo === 'object' and has exactly the same optimizations, so there's zero need for %_IsObject in our code base. R=mstarzinger@chromium.org Committed: https://crrev.com/b4c7399464481d31c2a78a64f79a6c7e09f1add9 Cr-Commit-Position: refs/heads/master@{#30380}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Michis comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -947 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -17 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/ppc/lithium-ppc.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +0 lines, -17 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/constant-fold-control-instructions.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 3 months ago (2015-08-26 10:30:33 UTC) #1
Benedikt Meurer
Hey Michi, Removing redundant code... Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-08-26 10:31:19 UTC) #2
Yang
On 2015/08/26 10:31:19, Benedikt Meurer wrote: > Hey Michi, > > Removing redundant code... > ...
5 years, 3 months ago (2015-08-26 10:35:18 UTC) #3
Michael Starzinger
LGTM. LOL. https://codereview.chromium.org/1313903003/diff/1/test/cctest/compiler/test-run-jscalls.cc File test/cctest/compiler/test-run-jscalls.cc (left): https://codereview.chromium.org/1313903003/diff/1/test/cctest/compiler/test-run-jscalls.cc#oldcode160 test/cctest/compiler/test-run-jscalls.cc:160: FunctionTester T("(function(a) { return %_IsObject(a); })"); nit: ...
5 years, 3 months ago (2015-08-26 10:47:11 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1313903003/diff/1/test/cctest/compiler/test-run-jscalls.cc File test/cctest/compiler/test-run-jscalls.cc (left): https://codereview.chromium.org/1313903003/diff/1/test/cctest/compiler/test-run-jscalls.cc#oldcode160 test/cctest/compiler/test-run-jscalls.cc:160: FunctionTester T("(function(a) { return %_IsObject(a); })"); On 2015/08/26 10:47:10, ...
5 years, 3 months ago (2015-08-26 10:50:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313903003/20001
5 years, 3 months ago (2015-08-26 10:50:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 11:28:05 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 11:28:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4c7399464481d31c2a78a64f79a6c7e09f1add9
Cr-Commit-Position: refs/heads/master@{#30380}

Powered by Google App Engine
This is Rietveld 408576698