Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 13139002: Remove support for 'dart:scalarlist' in the Dart VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intrinsifier_x64.cc
===================================================================
--- runtime/vm/intrinsifier_x64.cc (revision 20600)
+++ runtime/vm/intrinsifier_x64.cc (working copy)
@@ -411,23 +411,6 @@
}
-
-// Tests if index is a valid length (Smi and within valid index range),
-// jumps to fall_through if it is not.
-// Returns index in R12, array in RAX.
-// This should be used only on getIndexed intrinsics.
-void TestByteArrayGetIndex(Assembler* assembler, Label* fall_through) {
- __ movq(RAX, Address(RSP, + 2 * kWordSize)); // Array.
- __ movq(R12, Address(RSP, + 1 * kWordSize)); // Index.
- __ testq(R12, Immediate(kSmiTagMask));
- __ j(NOT_ZERO, fall_through, Assembler::kNearJump); // Non-smi index.
- // Range check.
- __ cmpq(R12, FieldAddress(RAX, ByteArray::length_offset()));
- // Runtime throws exception.
- __ j(ABOVE_EQUAL, fall_through, Assembler::kNearJump);
-}
-
-
#define TYPED_ARRAY_ALLOCATION(type_name, cid, max_len, scale_factor) \
Label fall_through; \
const intptr_t kArrayLengthStackOffset = 1 * kWordSize; \

Powered by Google App Engine
This is Rietveld 408576698