Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313893003: Don't resolve rectangle as different unit if viewport is empty (Closed)

Created:
5 years, 4 months ago by fs
Modified:
5 years, 4 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't resolve rectangle as different unit if viewport is empty SVGLengthContext::resolveRectangle would resolve oBB units as uSOU units if the "viewport" provided was empty. This would lead to incorrect rendering in certain cases - like with filters on content with an empty bbox. BUG=252696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201140

Patch Set 1 #

Patch Set 2 : TEs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/filters/feMerge-wrong-input.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/filters/feMerge-wrong-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/svg/filters/filter-empty-bbox-obb-filterunits.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/filter-empty-bbox-obb-filterunits-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 4 months ago (2015-08-25 13:07:01 UTC) #2
pdr.
lgtm
5 years, 4 months ago (2015-08-25 17:23:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313893003/20001
5 years, 4 months ago (2015-08-25 17:23:26 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 17:29:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201140

Powered by Google App Engine
This is Rietveld 408576698