Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313863002: Make SpellChecker::markAllMisspellingsAndBadGrammarInRanges() to take EphemeralRange (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make SpellChecker::markAllMisspellingsAndBadGrammarInRanges() to take EphemeralRange This patch changes |markAllMisspellingsAndBadGrammarInRanges()| member function of |SpellChecker| class to take |EphemeralRange| instead of |Range| to avoid registering temporary |Range| object into |Document|. This patch is also a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 to reduce DOM position dependency from |VisibleSelection| for ease of templatization of |VisibleSelection|. BUG=388681, 513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201117

Patch Set 1 : 2015-08-25T15:52:55 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-25 07:09:45 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-25 07:31:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313863002/1
5 years, 4 months ago (2015-08-25 07:41:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/44094)
5 years, 4 months ago (2015-08-25 08:20:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313863002/1
5 years, 4 months ago (2015-08-25 09:22:12 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 09:58:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201117

Powered by Google App Engine
This is Rietveld 408576698