Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: chrome/browser/ui/views/desktop_media_picker_views.cc

Issue 1313843003: Enable keyboard navigation for Desktopcapture window selection dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reiew update 4 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/desktop_media_picker_views.cc
diff --git a/chrome/browser/ui/views/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_media_picker_views.cc
index b2975b2b2309b25d1a1208e10f30ccd1bbb3a35c..9ed27baf80fd0ef73dc24e64bcdfa247b0226c33 100644
--- a/chrome/browser/ui/views/desktop_media_picker_views.cc
+++ b/chrome/browser/ui/views/desktop_media_picker_views.cc
@@ -206,6 +206,7 @@ DesktopMediaListView::DesktopMediaListView(
media_list_(media_list.Pass()),
weak_factory_(this) {
media_list_->SetThumbnailSize(gfx::Size(kThumbnailWidth, kThumbnailHeight));
+ SetFocusable(true);
}
DesktopMediaListView::~DesktopMediaListView() {}
@@ -443,6 +444,10 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(
}
list_view_->StartUpdating(dialog_window_id);
+
+ views::View* initView = GetInitiallyFocusedView();
Peter Kasting 2015/09/24 04:10:25 This block is still here. Why is it not removed?
gyzhou 2015/10/02 18:51:26 Done.
+ if (initView)
+ initView->RequestFocus();
}
DesktopMediaPickerDialogView::~DesktopMediaPickerDialogView() {}
@@ -480,6 +485,10 @@ void DesktopMediaPickerDialogView::Layout() {
rect.width(), rect.height() - scroll_view_top);
}
+views::View* DesktopMediaPickerDialogView::GetInitiallyFocusedView(){
+ return list_view_;
+}
+
ui::ModalType DesktopMediaPickerDialogView::GetModalType() const {
return ui::MODAL_TYPE_CHILD;
}

Powered by Google App Engine
This is Rietveld 408576698