Enable keyboard navigation for Desktopcapture window selection dialog

chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media/fake_desktop_media_list.h"
 #include "chrome/browser/ui/views/desktop_media_picker_views.h"
 #include "components/web_modal/test_web_contents_modal_dialog_host.h"
@@ skipping 69 matching lines @@
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
   GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnFocus();
   EXPECT_TRUE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
   GetPickerDialogView()->GetDialogClientView()->AcceptWindow();
   base::RunLoop().RunUntilIdle();
 }
 
+// Verifies that cancel button click leads to dialog close without notify a
+// selection of MediaSourceView.

[Peter Kasting, 2015/10/05 20:59:46]

The comments in and around these new tests have grammar problems.  Please work
with someone to help get them fixed.

It's not clear to me that this test actually verifies that no selection
notification occurs.  Where does that happen?

[gyzhou, 2015/10/05 21:12:27]

This it the reason I asked Sergey to specially pay attention to this because I
am not sure.

+TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledOnCancelButtonPressed) {
+  EXPECT_CALL(*this, OnPickerDone(content::DesktopMediaID()));
+
+  const int kFakeId = 222;
+  media_list_->AddSource(kFakeId);
+  GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnFocus();
+
+  GetPickerDialogView()->GetDialogClientView()->CancelWindow();
+  base::RunLoop().RunUntilIdle();
+}
+
+// Verifies that a MediaSourceView is selected with mouse left click and
+// original selected MediaSourceView gets unselected.
+TEST_F(DesktopMediaPickerViewsTest, SelectMediaSourceViewOnSingleClick) {
+  media_list_->AddSource(0);
+  media_list_->AddSource(1);
+
+  DesktopMediaSourceView* source_view_0 =
+      GetPickerDialogView()->GetMediaSourceViewForTesting(0);
+
+  DesktopMediaSourceView* source_view_1 =
+      GetPickerDialogView()->GetMediaSourceViewForTesting(1);
+
+  // Both media source views are not selected initially.
+  EXPECT_FALSE(source_view_0->is_selected());
+  EXPECT_FALSE(source_view_1->is_selected());
+
+  // Source view 0 is selected with mouse click.
+  ui::MouseEvent press(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
+                       ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON, 0);
+
+  GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnMousePressed(press);
+
+  EXPECT_TRUE(source_view_0->is_selected());
+  EXPECT_FALSE(source_view_1->is_selected());
+
+  // Source view 1 is selected and source view 0 is unselected with mouse click.
+  GetPickerDialogView()->GetMediaSourceViewForTesting(1)->OnMousePressed(press);
+
+  EXPECT_FALSE(source_view_0->is_selected());
+  EXPECT_TRUE(source_view_1->is_selected());
+}
+
 TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledOnDoubleClick) {
   const int kFakeId = 222;
   EXPECT_CALL(*this,
               OnPickerDone(content::DesktopMediaID(
                   content::DesktopMediaID::TYPE_WINDOW, kFakeId)));
 
   media_list_->AddSource(kFakeId);
 
   ui::MouseEvent double_click(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
                               ui::EventTimeForNow(),
@@ skipping 78 matching lines @@
 
   GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnFocus();
   EXPECT_TRUE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
   media_list_->RemoveSource(0);
   EXPECT_FALSE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 }
 
+// Verifies that the MediaListView get the initial focus.
+TEST_F(DesktopMediaPickerViewsTest, ListViewHasInitialFocus) {
+  EXPECT_TRUE(GetPickerDialogView()->GetMediaListViewForTesting()->HasFocus());
+}
+
 }  // namespace views