Enable keyboard navigation for Desktopcapture window selection dialog

chrome/browser/ui/views/desktop_media_picker_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/desktop_media_picker_views.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media/desktop_media_list.h"
@@ skipping 188 matching lines @@
   }
 }
 
 DesktopMediaListView::DesktopMediaListView(
     DesktopMediaPickerDialogView* parent,
     scoped_ptr<DesktopMediaList> media_list)
     : parent_(parent),
       media_list_(media_list.Pass()),
       weak_factory_(this) {
   media_list_->SetThumbnailSize(gfx::Size(kThumbnailWidth, kThumbnailHeight));
+  SetFocusable(true);
 }
 
 DesktopMediaListView::~DesktopMediaListView() {}
 
 void DesktopMediaListView::StartUpdating(DesktopMediaID dialog_window_id) {
   media_list_->SetViewDialogWindowId(dialog_window_id);
   media_list_->StartUpdating(this);
 }
 
 void DesktopMediaListView::OnSelectionChanged() {
@@ skipping 217 matching lines @@
 #endif
 
     // Set native window ID if the windows is outside Ash.
     if (!is_ash_window) {
       dialog_window_id.id = AcceleratedWidgetToDesktopMediaId(
           widget->GetNativeWindow()->GetHost()->GetAcceleratedWidget());
     }
   }
 
   list_view_->StartUpdating(dialog_window_id);
+
+  GetInitiallyFocusedView()->RequestFocus();

[Peter Kasting, 2015/09/24 20:46:56]

I've asked several times why this code is still here and you repeatedly haven't
answered and haven't removed it.  I don't understand why this is happening.

To reiterate what has already been explained: the whole point of using
GetInitiallyFocusedView() is to let the widget machinery focus the view for you.
 You should not be doing this yourself.  If you need to, something else is
broken elsewhere and this still isn't the right fix.  If you still don't
understand something, ask more questions about it, but don't let my feedback
simply go ignored.

[gyzhou, 2015/10/02 18:51:26]

Done.

 }
 
 DesktopMediaPickerDialogView::~DesktopMediaPickerDialogView() {}
 
 void DesktopMediaPickerDialogView::DetachParent() {
   parent_ = NULL;
 }
 
 gfx::Size DesktopMediaPickerDialogView::GetPreferredSize() const {
   static const size_t kDialogViewWidth = 600;
@@ skipping 32 matching lines @@
   return l10n_util::GetStringFUTF16(IDS_DESKTOP_MEDIA_PICKER_TITLE, app_name_);
 }
 
 bool DesktopMediaPickerDialogView::IsDialogButtonEnabled(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK)
     return list_view_->GetSelection() != NULL;
   return true;
 }
 
+views::View* DesktopMediaPickerDialogView::GetInitiallyFocusedView(){
+  return list_view_;
+}
+
 base::string16 DesktopMediaPickerDialogView::GetDialogButtonLabel(
     ui::DialogButton button) const {
   return l10n_util::GetStringUTF16(button == ui::DIALOG_BUTTON_OK ?
       IDS_DESKTOP_MEDIA_PICKER_SHARE : IDS_CANCEL);
 }
 
 bool DesktopMediaPickerDialogView::Accept() {
   DesktopMediaSourceView* selection = list_view_->GetSelection();
 
   // Ok button should only be enabled when a source is selected.
@@ skipping 77 matching lines @@
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(callback_, source));
   callback_.Reset();
 }
 
 // static
 scoped_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() {
   return scoped_ptr<DesktopMediaPicker>(new DesktopMediaPickerViews());
 }