Enable keyboard navigation for Desktopcapture window selection dialog

chrome/browser/ui/views/desktop_media_picker_views.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
 
 #include "chrome/browser/media/desktop_media_list_observer.h"
 #include "chrome/browser/media/desktop_media_picker.h"
 #include "ui/views/window/dialog_delegate.h"
@@ skipping 111 matching lines @@
   void DetachParent();
 
   // Called by DesktopMediaListView.
   void OnSelectionChanged();
   void OnDoubleClick();
 
   // views::View overrides.
   gfx::Size GetPreferredSize() const override;
   void Layout() override;
 
+  // views::DialogDelegate overrides.
+  views::View* GetInitiallyFocusedView() override;

[Peter Kasting, 2015/09/24 04:10:25]

You don't directly subclass DialogDelegate; you get this function through
DialogDelegateView, and that's the only override section you should have.  (The
existing separate section for View shouldn't exist either.)

Or to put it differently, this class doesn't care about how DialogDelegateView
is itself implemented, and if we were to change that someday to move this method
from one base class to another, we shouldn't need to check all subclasses (of
any depth) of all these classes to update the comments and organization of their
overrides.

[gyzhou, 2015/10/02 18:51:26]

Done.

+
   // views::DialogDelegateView overrides.
   ui::ModalType GetModalType() const override;
   base::string16 GetWindowTitle() const override;
   bool IsDialogButtonEnabled(ui::DialogButton button) const override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
   bool Accept() override;
   void DeleteDelegate() override;
 
   void OnMediaListRowsChanged();
 
@@ skipping 36 matching lines @@
 
   // The |dialog_| is owned by the corresponding views::Widget instance.
   // When DesktopMediaPickerViews is destroyed the |dialog_| is destroyed
   // asynchronously by closing the widget.
   DesktopMediaPickerDialogView* dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopMediaPickerViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_