[not for landing] Diff between a64 and r19234 for no-a64 files.

src/builtins.cc

Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index e68890fcb292b71f831a6b650378880f98941692..cf5e0e94159792b188dd04eead689afbd72a039d 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -1627,7 +1627,9 @@ void Builtins::SetUp(Isolate* isolate, bool create_heap_objects) {
   // For now we generate builtin adaptor code into a stack-allocated
   // buffer, before copying it into individual code objects. Be careful
   // with alignment, some platforms don't like unaligned code.
-  union { int force_alignment; byte buffer[8*KB]; } u;
+  // TODO(jbramley): I had to increase the size of this buffer from 8KB because
+  // we can generate a lot of debug code on A64.

[rmcilroy, 2014/02/11 18:31:06]

Is this still required?

[Rodolph Perfetta, 2014/02/12 01:08:24]

Yes, when in debug we generate a fair amount of extra code.

On 2014/02/11 18:31:06, rmcilroy wrote:

+  union { int force_alignment; byte buffer[16*KB]; } u;
 
   // Traverse the list of builtins and generate an adaptor in a
   // separate code object for each one.