[not for landing] Diff between a64 and r19234 for no-a64 files.

test/mjsunit/div-mod.js

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 108 matching lines @@
   var finite_decimal = 0.5;
   var smi = 43;
   var power_of_two = 64;
   var min_normal = Number.MIN_VALUE * Math.pow(2, 52);
   var max_denormal = Number.MIN_VALUE * (Math.pow(2, 52) - 1);
 
   // All combinations of NaN, Infinity, normal, denormal and zero.
   var example_numbers = [
     NaN,
     0,
-    Number.MIN_VALUE,
-    3 * Number.MIN_VALUE,
-    max_denormal,
+
+    // TODO(all): due to a bug in fmod(), modulos involving denormals

[ulan, 2014/02/11 17:24:26]

Remove before merge?

[Rodolph Perfetta, 2014/02/11 17:58:29]

Yes but maybe leave a comment that those tests may fail on older libc?


On 2014/02/11 17:24:26, ulan wrote:

+    // return the wrong result for glibc <= 2.16. Restore these cases when
+    // development machines have been upgraded.
+    // Details: http://sourceware.org/bugzilla/show_bug.cgi?id=14048
+
+    // Number.MIN_VALUE,
+    // 3 * Number.MIN_VALUE,
+    // max_denormal,
+
     min_normal,
     repeating_decimal,
     finite_decimal,
     smi,
     power_of_two,
     small_non_smi,
     large_non_smi,
     Number.MAX_VALUE,
     Infinity
   ];
@@ skipping 153 matching lines @@
     assertEquals(-results_powers_of_two[i][28], -left_operands[i] % -(2 << 28));
     assertEquals(-results_powers_of_two[i][29], -left_operands[i] % (2 << 29));
     assertEquals(-results_powers_of_two[i][30], -left_operands[i] % -(2 << 30));
   }
 
 }
 
 lithium_integer_mod();
 %OptimizeFunctionOnNextCall(lithium_integer_mod)
 lithium_integer_mod();