[not for landing] Diff between a64 and r19234 for no-a64 files.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 289 matching lines @@
 
 OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {
   ASSERT(isolate()->use_crankshaft());
   ASSERT(info()->IsOptimizing());
   ASSERT(!info()->IsCompilingForDebugging());
 
   // We should never arrive here if there is no code object on the
   // shared function object.
   ASSERT(info()->shared_info()->code()->kind() == Code::FUNCTION);
 
+  if (FLAG_trace_opt) {

[ulan, 2014/02/11 17:24:26]

Remove before landing?

[Rodolph Perfetta, 2014/02/11 17:58:29]

Yes remove.

On 2014/02/11 17:24:26, ulan wrote:

+    // TODO(jbramley): This was added to help analyse the behaviour of
+    // Crankshaft for the A64 Crankshaft port. It should eventually be deleted.
+    Handle<JSFunction> function = info()->closure();
+    PrintF("Attempting optimization of ");
+    function->PrintName();
+    PrintF(" / %" V8PRIxPTR "\n", reinterpret_cast<intptr_t>(*function));
+  }
+
   // We should never arrive here if optimization has been disabled on the
   // shared function info.
   ASSERT(!info()->shared_info()->optimization_disabled());
 
   // Fall back to using the full code generator if it's not possible
   // to use the Hydrogen-based optimizing compiler. We already have
   // generated code for this from the shared function object.
   if (FLAG_always_full_compiler) return AbortOptimization();
   if (IsDebuggerActive(isolate())) return AbortOptimization(kDebuggerIsActive);
 
@@ skipping 971 matching lines @@
   AllowHandleDereference allow_deref;
   bool tracing_on = info()->IsStub()
       ? FLAG_trace_hydrogen_stubs
       : (FLAG_trace_hydrogen &&
          info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
   return (tracing_on &&
       OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
 }
 
 } }  // namespace v8::internal