Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313783007: Fix assertion about GPU memory size when the target is not FBO 0 (Closed)

Created:
5 years, 3 months ago by Chinmay
Modified:
5 years, 3 months ago
CC:
reviews_skia.org, abarth-chromium, eseidel, eseidel1
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix assertion about GPU memory size when the target is not FBO 0 Committed: https://skia.googlesource.com/skia/+/fe495f0bae96c732730a7d6b2667662c4d67bfa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGLRenderTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Chinmay
5 years, 3 months ago (2015-08-26 23:08:40 UTC) #2
eseidel1
Is there someone on the blame list for this file that we should CC here?
5 years, 3 months ago (2015-08-26 23:19:00 UTC) #4
Chinmay
5 years, 3 months ago (2015-08-26 23:22:34 UTC) #6
bsalomon
On 2015/08/26 23:22:34, Chinmay wrote: lgtm
5 years, 3 months ago (2015-08-27 13:00:01 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313783007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313783007/1
5 years, 3 months ago (2015-08-27 13:23:17 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 13:28:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313783007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313783007/1
5 years, 3 months ago (2015-08-27 13:35:59 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 13:36:37 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fe495f0bae96c732730a7d6b2667662c4d67bfa1

Powered by Google App Engine
This is Rietveld 408576698