Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1313773002: Fix android adb version match (Closed)

Created:
5 years, 4 months ago by boliu
Modified:
5 years, 4 months ago
Reviewers:
Xianzhu
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix android adb version match With M SDK, the output of "adb version" has changed, from: """Android Debug Bridge version 1.0.32""" to: """Android Debug Bridge version 1.0.32 Revision 57224c5cff69-android""" Update script regex to match both. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
boliu
ptal? I think anyone can review changes here, right?
5 years, 4 months ago (2015-08-24 22:07:02 UTC) #2
Xianzhu
lgtm
5 years, 4 months ago (2015-08-24 22:09:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313773002/1
5 years, 4 months ago (2015-08-24 22:09:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103381)
5 years, 4 months ago (2015-08-24 23:57:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313773002/1
5 years, 4 months ago (2015-08-24 23:58:13 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 00:24:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201081

Powered by Google App Engine
This is Rietveld 408576698