Support gesture events in WebFrameWidgetImpl.

Support gesture events in WebFrameWidgetImpl.

Mandoline uses WebFrameWidgetImpl for an iframe, and it could
be in a separate process from the main frame. And touch events
are dispatched to iframe directly, so this CL add gesture support 
for WebFrameWidgetImpl.


BUG=522592
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201499

[Peng, 2015-08-26 17:58:14]

penghuang@chromium.org changed reviewers:
+ dcheng@chromium.org

[Peng, 2015-08-26 17:58:15]

Hi Daniel, Could you please take a look? Thanks.

[dcheng, 2015-08-26 19:55:18]

Some questions:
1) This looks pretty different from WebViewImpl::handleGestureEvent. Will we
eventually need to port the logic in there over to here as well?
2) Can we/should we add a test for the specific behavior we're fixing here?

[Peng, 2015-08-26 20:16:06]

On 2015/08/26 19:55:18, dcheng wrote:
> Some questions:
> 1) This looks pretty different from WebViewImpl::handleGestureEvent. Will we
> eventually need to port the logic in there over to here as well?

Probably not, some gestures doesn't make sense for an iframe. They must be
handled by the main frame (fling, pinch to zoom, etc).
Right now, we just need support tap to switch focused node in an iframe and
scroll, so we can have a workable OOPIF.

> 2) Can we/should we add a test for the specific behavior we're fixing here?
I tested mandoline with http://phuang.github.io/iframe.html. It does fix the
issue.
I don't know how to create an auto test for it. Do you know similar tests, so I
can have a look?

[dcheng, 2015-08-26 23:28:43]

On 2015/08/26 at 20:16:06, penghuang wrote:
> On 2015/08/26 19:55:18, dcheng wrote:
> > Some questions:
> > 1) This looks pretty different from WebViewImpl::handleGestureEvent. Will we
> > eventually need to port the logic in there over to here as well?
> 
> Probably not, some gestures doesn't make sense for an iframe. They must be
handled by the main frame (fling, pinch to zoom, etc).
> Right now, we just need support tap to switch focused node in an iframe and
scroll, so we can have a workable OOPIF.
> 
> > 2) Can we/should we add a test for the specific behavior we're fixing here?
> I tested mandoline with http://phuang.github.io/iframe.html. It does fix the
issue.
> I don't know how to create an auto test for it. Do you know similar tests, so
I can have a look?

There's no automated testing of stuff in webFrameWidget (yet) but that does seem
like something we should address sooner rather than later.

There are bunch of tests relating to frame swapping in WebFrameTests.cpp (search
for WebFrameSwapTest). That will give a basic idea of how to set up the frame
tree correctly. After that, I think it's just a matter of correctly attaching
the WebFrameWidget to the local frame: ideally, then we can dispatch events at
it and test that things are working.

[Peng, 2015-08-28 17:17:30]

Hi Daniel, I added a test. PTAL. Thanks.

[dcheng, 2015-08-31 16:51:20]

https://codereview.chromium.org/1313763004/diff/60001/Source/web/WebFrameWidg...
File Source/web/WebFrameWidgetImpl.cpp (right):

https://codereview.chromium.org/1313763004/diff/60001/Source/web/WebFrameWidg...
Source/web/WebFrameWidgetImpl.cpp:748: const LocalFrame* frame =
m_localRoot->frame();
Nit: const here looks weird: handling a gesture event doesn't really seem like
an action that wouldn't change any state on the frame.

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7595: class MockTestWebViewClient : public
FrameTestHelpers::TestWebViewClient {
MockTestWebViewClient -> GestureEventTestWebViewClient? Mock is a very generic
name, but this class has a pretty focused purpose.

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7599: bool didHandleGestureEvent() { return
m_didHandleGestureEvent; }
Nit: const

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7600: bool m_didHandleGestureEvent;
And make this private.

[Peng, 2015-08-31 17:34:58]

https://codereview.chromium.org/1313763004/diff/60001/Source/web/WebFrameWidg...
File Source/web/WebFrameWidgetImpl.cpp (right):

https://codereview.chromium.org/1313763004/diff/60001/Source/web/WebFrameWidg...
Source/web/WebFrameWidgetImpl.cpp:748: const LocalFrame* frame =
m_localRoot->frame();
On 2015/08/31 16:51:20, dcheng wrote:
> Nit: const here looks weird: handling a gesture event doesn't really seem like
> an action that wouldn't change any state on the frame.

Done.

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7595: class MockTestWebViewClient : public
FrameTestHelpers::TestWebViewClient {
On 2015/08/31 16:51:20, dcheng wrote:
> MockTestWebViewClient -> GestureEventTestWebViewClient? Mock is a very generic
> name, but this class has a pretty focused purpose.

Done.

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7599: bool didHandleGestureEvent() { return
m_didHandleGestureEvent; }
On 2015/08/31 16:51:20, dcheng wrote:
> Nit: const

Done.

https://codereview.chromium.org/1313763004/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7600: bool m_didHandleGestureEvent;
On 2015/08/31 16:51:20, dcheng wrote:
> And make this private.

Done.

[dcheng, 2015-08-31 18:23:05]

lgtm

[Peng, 2015-08-31 18:23:23]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2015-08-31 18:23:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313763004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313763004/100001

[commit-bot: I haz the power, 2015-08-31 19:51:49]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201499