Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: Source/core/html/HTMLAppletElement.cpp

Issue 1313763002: Blink Plugins: Remove Shadow DOM Plugin Placeholder (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLAppletElement.cpp
diff --git a/Source/core/html/HTMLAppletElement.cpp b/Source/core/html/HTMLAppletElement.cpp
index af9de0c88e87fca22ffd82d0d6118bbd4bc7fb16..3aa6727f065ae452178cbab7216130f4a4ac5220 100644
--- a/Source/core/html/HTMLAppletElement.cpp
+++ b/Source/core/html/HTMLAppletElement.cpp
@@ -35,7 +35,6 @@
#include "core/layout/LayoutBlockFlow.h"
#include "core/loader/FrameLoader.h"
#include "core/loader/FrameLoaderClient.h"
-#include "core/plugins/PluginPlaceholder.h"
#include "platform/Widget.h"
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/SecurityOrigin.h"
@@ -95,9 +94,6 @@ LayoutObject* HTMLAppletElement::createLayoutObject(const ComputedStyle& style)
if (!canEmbedJava() || openShadowRoot())
return LayoutObject::createObject(this, style);
- if (usePlaceholderContent())
- return new LayoutBlockFlow(this);
-
return new LayoutApplet(this);
}
@@ -188,25 +184,17 @@ void HTMLAppletElement::updateWidgetInternal()
paramValues.append(param->value());
}
- OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder = nullptr;
RefPtrWillBeRawPtr<Widget> widget = nullptr;
- if (frame->loader().allowPlugins(AboutToInstantiatePlugin)) {
- placeholder = frame->loader().client()->createPluginPlaceholder(document(), KURL(), paramNames, paramValues, m_serviceType, false);
- if (!placeholder)
- widget = frame->loader().client()->createJavaAppletWidget(this, baseURL, paramNames, paramValues);
- }
+ if (frame->loader().allowPlugins(AboutToInstantiatePlugin))
+ widget = frame->loader().client()->createJavaAppletWidget(this, baseURL, paramNames, paramValues);
- if (!placeholder && !widget) {
+ if (!widget) {
if (!layoutObject->showsUnavailablePluginIndicator())
layoutObject->setPluginUnavailabilityReason(LayoutEmbeddedObject::PluginMissing);
- setPlaceholder(nullptr);
- } else if (placeholder) {
- setPlaceholder(placeholder.release());
- } else if (widget) {
- document().setContainsPlugins();
- setWidget(widget);
- setPlaceholder(nullptr);
+ return;
}
+ document().setContainsPlugins();
+ setWidget(widget);
}
bool HTMLAppletElement::canEmbedJava() const

Powered by Google App Engine
This is Rietveld 408576698