Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1313733013: Remove IPDFSDK_AnnotHandler interface. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove IPDFSDK_AnnotHandler interface. It's pointless to have an abstract interface and its only concrete implementation defined in the same header. We can de-virtualize along the way and get a small savings. Rename CPDFSDK_BFAnnotHandler along the way, since its the only kind of AnnotHandler, and I can't imagine what BF stands for. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/633f1e436e1cced874a44a797f02c452eb3cf958

Patch Set 1 #

Patch Set 2 : Remove comment. #

Patch Set 3 : De-crapify #

Total comments: 4

Patch Set 4 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -238 lines) Patch
M fpdfsdk/include/fsdk_annothandler.h View 1 2 3 4 chunks +44 lines, -148 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 45 chunks +90 lines, -90 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, more cleanup.
5 years, 3 months ago (2015-09-01 21:26:55 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1313733013/diff/40001/fpdfsdk/include/fsdk_annothandler.h File fpdfsdk/include/fsdk_annothandler.h (right): https://codereview.chromium.org/1313733013/diff/40001/fpdfsdk/include/fsdk_annothandler.h#newcode26 fpdfsdk/include/fsdk_annothandler.h:26: CPDFSDK_AnnotHandler(CPDFDoc_Environment* pApp) explicit https://codereview.chromium.org/1313733013/diff/40001/fpdfsdk/include/fsdk_annothandler.h#newcode27 fpdfsdk/include/fsdk_annothandler.h:27: : m_pApp(pApp), m_pFormFiller(NULL) ...
5 years, 3 months ago (2015-09-01 21:33:30 UTC) #3
Tom Sepez
Committed patchset #4 (id:60001) manually as 633f1e436e1cced874a44a797f02c452eb3cf958 (presubmit successful).
5 years, 3 months ago (2015-09-01 22:02:02 UTC) #4
Tom Sepez
On 2015/09/01 22:02:02, Tom Sepez wrote: > Committed patchset #4 (id:60001) manually as > 633f1e436e1cced874a44a797f02c452eb3cf958 ...
5 years, 3 months ago (2015-09-01 22:05:21 UTC) #5
Tom Sepez
5 years, 3 months ago (2015-09-01 22:05:30 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1313733013/diff/40001/fpdfsdk/include/fsdk_an...
File fpdfsdk/include/fsdk_annothandler.h (right):

https://codereview.chromium.org/1313733013/diff/40001/fpdfsdk/include/fsdk_an...
fpdfsdk/include/fsdk_annothandler.h:26:
CPDFSDK_AnnotHandler(CPDFDoc_Environment* pApp)
On 2015/09/01 21:33:30, Lei Zhang wrote:
> explicit

Done.

https://codereview.chromium.org/1313733013/diff/40001/fpdfsdk/include/fsdk_an...
fpdfsdk/include/fsdk_annothandler.h:27: : m_pApp(pApp), m_pFormFiller(NULL) {}
On 2015/09/01 21:33:30, Lei Zhang wrote:
> nullptr

Done.

Powered by Google App Engine
This is Rietveld 408576698