Allowing registering arbitrary schemes as supporting the fetch API.

Source/platform/weborigin/SchemeRegistry.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 158 matching lines @@
         // HTTP is required because http://localhost is considered secure.
         // Additional checks are performed to ensure that other http pages
         // are filtered out.
         serviceWorkerSchemes.add("http");
         serviceWorkerSchemes.add("https");
     }
 
     return serviceWorkerSchemes;
 }
 
+static URLSchemesSet& fetchAPISchemes()
+{
+    assertLockHeld();
+    DEFINE_STATIC_LOCAL_NOASSERT(URLSchemesSet, fetchAPISchemes, ());
+
+    if (fetchAPISchemes.isEmpty()) {
+        fetchAPISchemes.add("http");
+        fetchAPISchemes.add("https");
+    }
+
+    return fetchAPISchemes;
+}
+
 static URLSchemesMap<SchemeRegistry::PolicyAreas>& ContentSecurityPolicyBypassingSchemes()
 {
     assertLockHeld();
     DEFINE_STATIC_LOCAL_NOASSERT(URLSchemesMap<SchemeRegistry::PolicyAreas>, schemes, ());
     return schemes;
 }
 
 bool SchemeRegistry::shouldTreatURLSchemeAsLocal(const String& scheme)
 {
     if (scheme.isEmpty())
@@ skipping 157 matching lines @@
 }
 
 bool SchemeRegistry::shouldTreatURLSchemeAsAllowingServiceWorkers(const String& scheme)
 {
     if (scheme.isEmpty())
         return false;
     MutexLocker locker(mutex());
     return serviceWorkerSchemes().contains(scheme);
 }
 
+void SchemeRegistry::registerURLSchemeAsSupportingFetchAPI(const String& scheme)
+{
+    MutexLocker locker(mutex());
+    fetchAPISchemes().add(scheme);
+}
+
+bool SchemeRegistry::shouldTreatURLSchemeAsSupportingFetchAPI(const String& scheme)
+{
+    if (scheme.isEmpty())

[dcheng, 2015/08/25 20:07:32]

Out of curiosity, any particular reason to special case this?

[not at google - send to devlin, 2015/08/25 20:09:03]

No idea, I just copied service worker code, but I agree in both cases it's weird
to be checking for an empty scheme here. It's (hopefully) not like URLSchemesSet
will crash with an empty scheme.

[pdr., 2015/08/25 21:25:10]

Lets just assert !scheme.isEmpty().

[not at google - send to devlin, 2015/08/25 22:04:45]

SGTM, if you're confident, but it would be odd for this function to be different
from every other which does check for it. I'd be more comfortable in just
removing every check.

[tyoshino (SeeGerritForStatus), 2015/08/26 07:24:48]

+1. Change to other methods could be done as a separate CL.

[not at google - send to devlin, 2015/08/26 16:30:32]

Acknowledged.

+        return false;
+    MutexLocker locker(mutex());
+    return fetchAPISchemes().contains(scheme);
+}
+
 void SchemeRegistry::registerURLSchemeAsBypassingContentSecurityPolicy(const String& scheme, PolicyAreas policyAreas)
 {
     MutexLocker locker(mutex());
     ContentSecurityPolicyBypassingSchemes().add(scheme, policyAreas);
 }
 
 void SchemeRegistry::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy(const String& scheme)
 {
     MutexLocker locker(mutex());
     ContentSecurityPolicyBypassingSchemes().remove(scheme);
 }
 
 bool SchemeRegistry::schemeShouldBypassContentSecurityPolicy(const String& scheme, PolicyAreas policyAreas)
 {
     ASSERT(policyAreas != PolicyAreaNone);
     if (scheme.isEmpty() || policyAreas == PolicyAreaNone)
         return false;
 
     // get() returns 0 (PolicyAreaNone) if there is no entry in the map.
     // Thus by default, schemes do not bypass CSP.
     MutexLocker locker(mutex());
     return (ContentSecurityPolicyBypassingSchemes().get(scheme) & policyAreas) == policyAreas;
 }
 
 } // namespace blink