Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313613003: Fix a bug that current time can go backwards when playing a video (Closed)

Created:
5 years, 4 months ago by qinmin
Modified:
5 years, 3 months ago
Reviewers:
philipj_slow, xhwang
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that current time can go backwards when playing a video The line in this CL doesn't match the comments above it and should be fixed. BUG=509010 Committed: https://crrev.com/281684437cacd4de56fe3d06194fe64ea98d0671 Cr-Commit-Position: refs/heads/master@{#345633}

Patch Set 1 #

Patch Set 2 : fix the flakiness in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
qinmin
PTAL
5 years, 4 months ago (2015-08-25 17:12:49 UTC) #2
qinmin
+xhwang for OWNER
5 years, 4 months ago (2015-08-25 17:13:30 UTC) #4
xhwang
lgtm
5 years, 4 months ago (2015-08-25 18:27:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313613003/1
5 years, 4 months ago (2015-08-25 18:38:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/60509)
5 years, 4 months ago (2015-08-25 20:53:21 UTC) #9
philipj_slow
LGTM, makes sense!
5 years, 4 months ago (2015-08-26 07:12:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313613003/1
5 years, 3 months ago (2015-08-26 17:54:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313613003/20001
5 years, 3 months ago (2015-08-26 18:25:26 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 19:13:50 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 19:14:48 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/281684437cacd4de56fe3d06194fe64ea98d0671
Cr-Commit-Position: refs/heads/master@{#345633}

Powered by Google App Engine
This is Rietveld 408576698