Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc

Issue 1313603003: Vectorize website settings icons in omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change DCHECK Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "chrome/browser/chrome_notification_types.h" 6 #include "chrome/browser/chrome_notification_types.h"
7 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 7 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
8 #include "chrome/browser/prerender/prerender_manager.h" 8 #include "chrome/browser/prerender/prerender_manager.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/content_settings/content_setting_image_model.h" 10 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 }; 56 };
57 57
58 TEST_F(ContentSettingImageModelTest, UpdateFromWebContents) { 58 TEST_F(ContentSettingImageModelTest, UpdateFromWebContents) {
59 TabSpecificContentSettings::CreateForWebContents(web_contents()); 59 TabSpecificContentSettings::CreateForWebContents(web_contents());
60 TabSpecificContentSettings* content_settings = 60 TabSpecificContentSettings* content_settings =
61 TabSpecificContentSettings::FromWebContents(web_contents()); 61 TabSpecificContentSettings::FromWebContents(web_contents());
62 scoped_ptr<ContentSettingImageModel> content_setting_image_model( 62 scoped_ptr<ContentSettingImageModel> content_setting_image_model(
63 ContentSettingImageModel::CreateContentSettingImageModel( 63 ContentSettingImageModel::CreateContentSettingImageModel(
64 CONTENT_SETTINGS_TYPE_IMAGES)); 64 CONTENT_SETTINGS_TYPE_IMAGES));
65 EXPECT_FALSE(content_setting_image_model->is_visible()); 65 EXPECT_FALSE(content_setting_image_model->is_visible());
66 EXPECT_EQ(0, content_setting_image_model->get_icon()); 66 EXPECT_TRUE(content_setting_image_model->icon().IsEmpty());
67 EXPECT_TRUE(content_setting_image_model->get_tooltip().empty()); 67 EXPECT_TRUE(content_setting_image_model->get_tooltip().empty());
68 68
69 content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES); 69 content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES);
70 content_setting_image_model->UpdateFromWebContents(web_contents()); 70 content_setting_image_model->UpdateFromWebContents(web_contents());
71 71
72 EXPECT_TRUE(content_setting_image_model->is_visible()); 72 EXPECT_TRUE(content_setting_image_model->is_visible());
73 EXPECT_NE(0, content_setting_image_model->get_icon()); 73 EXPECT_FALSE(content_setting_image_model->icon().IsEmpty());
74 EXPECT_FALSE(content_setting_image_model->get_tooltip().empty()); 74 EXPECT_FALSE(content_setting_image_model->get_tooltip().empty());
75 } 75 }
76 76
77 TEST_F(ContentSettingImageModelTest, RPHUpdateFromWebContents) { 77 TEST_F(ContentSettingImageModelTest, RPHUpdateFromWebContents) {
78 TabSpecificContentSettings::CreateForWebContents(web_contents()); 78 TabSpecificContentSettings::CreateForWebContents(web_contents());
79 scoped_ptr<ContentSettingImageModel> content_setting_image_model( 79 scoped_ptr<ContentSettingImageModel> content_setting_image_model(
80 ContentSettingImageModel::CreateContentSettingImageModel( 80 ContentSettingImageModel::CreateContentSettingImageModel(
81 CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS)); 81 CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS));
82 content_setting_image_model->UpdateFromWebContents(web_contents()); 82 content_setting_image_model->UpdateFromWebContents(web_contents());
83 EXPECT_FALSE(content_setting_image_model->is_visible()); 83 EXPECT_FALSE(content_setting_image_model->is_visible());
(...skipping 10 matching lines...) Expand all
94 TEST_F(ContentSettingImageModelTest, CookieAccessed) { 94 TEST_F(ContentSettingImageModelTest, CookieAccessed) {
95 TabSpecificContentSettings::CreateForWebContents(web_contents()); 95 TabSpecificContentSettings::CreateForWebContents(web_contents());
96 TabSpecificContentSettings* content_settings = 96 TabSpecificContentSettings* content_settings =
97 TabSpecificContentSettings::FromWebContents(web_contents()); 97 TabSpecificContentSettings::FromWebContents(web_contents());
98 profile()->GetHostContentSettingsMap()->SetDefaultContentSetting( 98 profile()->GetHostContentSettingsMap()->SetDefaultContentSetting(
99 CONTENT_SETTINGS_TYPE_COOKIES, CONTENT_SETTING_BLOCK); 99 CONTENT_SETTINGS_TYPE_COOKIES, CONTENT_SETTING_BLOCK);
100 scoped_ptr<ContentSettingImageModel> content_setting_image_model( 100 scoped_ptr<ContentSettingImageModel> content_setting_image_model(
101 ContentSettingImageModel::CreateContentSettingImageModel( 101 ContentSettingImageModel::CreateContentSettingImageModel(
102 CONTENT_SETTINGS_TYPE_COOKIES)); 102 CONTENT_SETTINGS_TYPE_COOKIES));
103 EXPECT_FALSE(content_setting_image_model->is_visible()); 103 EXPECT_FALSE(content_setting_image_model->is_visible());
104 EXPECT_EQ(0, content_setting_image_model->get_icon()); 104 EXPECT_TRUE(content_setting_image_model->icon().IsEmpty());
105 EXPECT_TRUE(content_setting_image_model->get_tooltip().empty()); 105 EXPECT_TRUE(content_setting_image_model->get_tooltip().empty());
106 106
107 net::CookieOptions options; 107 net::CookieOptions options;
108 content_settings->OnCookieChanged(GURL("http://google.com"), 108 content_settings->OnCookieChanged(GURL("http://google.com"),
109 GURL("http://google.com"), 109 GURL("http://google.com"),
110 "A=B", 110 "A=B",
111 options, 111 options,
112 false); 112 false);
113 content_setting_image_model->UpdateFromWebContents(web_contents()); 113 content_setting_image_model->UpdateFromWebContents(web_contents());
114 EXPECT_TRUE(content_setting_image_model->is_visible()); 114 EXPECT_TRUE(content_setting_image_model->is_visible());
115 EXPECT_NE(0, content_setting_image_model->get_icon()); 115 EXPECT_FALSE(content_setting_image_model->icon().IsEmpty());
116 EXPECT_FALSE(content_setting_image_model->get_tooltip().empty()); 116 EXPECT_FALSE(content_setting_image_model->get_tooltip().empty());
117 } 117 }
118 118
119 // Regression test for http://crbug.com/161854. 119 // Regression test for http://crbug.com/161854.
120 TEST_F(ContentSettingImageModelTest, NULLTabSpecificContentSettings) { 120 TEST_F(ContentSettingImageModelTest, NULLTabSpecificContentSettings) {
121 scoped_ptr<ContentSettingImageModel> content_setting_image_model( 121 scoped_ptr<ContentSettingImageModel> content_setting_image_model(
122 ContentSettingImageModel::CreateContentSettingImageModel( 122 ContentSettingImageModel::CreateContentSettingImageModel(
123 CONTENT_SETTINGS_TYPE_IMAGES)); 123 CONTENT_SETTINGS_TYPE_IMAGES));
124 NotificationForwarder forwarder(content_setting_image_model.get()); 124 NotificationForwarder forwarder(content_setting_image_model.get());
125 // Should not crash. 125 // Should not crash.
126 TabSpecificContentSettings::CreateForWebContents(web_contents()); 126 TabSpecificContentSettings::CreateForWebContents(web_contents());
127 forwarder.clear(); 127 forwarder.clear();
128 } 128 }
129 129
130 } // namespace 130 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698