Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1313593003: Use the Chrome icon rather than a bell icon for notifications (Closed)

Created:
5 years, 4 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the Chrome icon rather than a bell icon for notifications The generic bell icon is deemed to be confusing, as it creates an association with alarms rather than generic notifications. Use the Chrome icon instead. BUG=523990 Committed: https://crrev.com/1598c3b20079643e0fea748797bf4a6e3c015549 Cr-Commit-Position: refs/heads/master@{#345589}

Patch Set 1 #

Patch Set 2 : new assets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A chrome/android/java/res/drawable-hdpi/ic_chrome.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_stat_notify.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/notification_badge.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_chrome.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_stat_notify.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/notification_badge.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_chrome.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_stat_notify.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/notification_badge.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_chrome.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/notification_badge.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_chrome.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/notification_badge.png View Binary file 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
+miguelg for notifications, newt for assets PTAL
5 years, 4 months ago (2015-08-25 19:07:46 UTC) #2
Miguel Garcia
lgtm
5 years, 4 months ago (2015-08-25 19:09:30 UTC) #3
newt (away)
lgtm
5 years, 4 months ago (2015-08-25 20:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313593003/20001
5 years, 3 months ago (2015-08-26 12:17:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 12:21:26 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 12:22:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1598c3b20079643e0fea748797bf4a6e3c015549
Cr-Commit-Position: refs/heads/master@{#345589}

Powered by Google App Engine
This is Rietveld 408576698