Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1313553008: Inject pylib first in the path. This ensures that test load the version (Closed)

Created:
5 years, 3 months ago by lindleyf
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Inject pylib first in the path. This ensures that test load the version of pylib in this repo, not elsewhere on the system. BUG= R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/a6c180603c7588797f35e01d8e4031279b735134 Committed: https://chromium.googlesource.com/external/gyp/+/bae26e800c7fcb1d4c15fcae71045189701fe3af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M gyp_main.py View 1 chunk +5 lines, -7 lines 0 comments Download
M test/small/gyptest-small.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
lindleyf
5 years, 3 months ago (2015-08-31 18:11:21 UTC) #2
Nico
lgtm
5 years, 3 months ago (2015-08-31 18:18:28 UTC) #3
lindleyf
Committed patchset #1 (id:1) manually as a6c180603c7588797f35e01d8e4031279b735134 (presubmit successful).
5 years, 3 months ago (2015-08-31 18:21:41 UTC) #4
Nico
5 years, 3 months ago (2015-08-31 18:37:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bae26e800c7fcb1d4c15fcae71045189701fe3af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698